New issue
Advanced search Search tips

Issue 670853 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Visual corruption when zooming in and out on https://www.elliottsprehn.com/examples/iframe-fouc-raf/

Project Member Reported by esprehn@chromium.org, Dec 2 2016

Issue description

Chrome Version: 57.0.2938.0 Canary
OS: Android 7, on a Pixel XL phone.

What steps will reproduce the problem?
(1) Load https://www.elliottsprehn.com/examples/iframe-fouc-raf/
(2) Zoom in and scroll down to the bottom.
(3) Zoom in and out and pan around.

Looks like random chunks of tiles appear all along the bottom of the screen.
 
Screenshot_20161201-205824.png
64.3 KB View Download
Screenshot_20161201-205818.png
53.0 KB View Download
Screenshot_20161201-205736.png
95.3 KB View Download
Screenshot_20161201-204933.png
65.3 KB View Download
Description: Show this description
Labels: -Type-Bug Needs-Bisect Type-Bug-Regression
I can reproduce this on my Pixel (not XL) canary, but not on stable. It seems pretty easy to reproduce so perhaps we can bisect this.
To add to this, the version I can't reproduce on is on 54.0.2840.85
Cc: acindhe@chromium.org
Labels: triage-te
Labels: -triage-te -Needs-Bisect
we are able to repro this issue on latest M57 - 57.0.2946.0 build with the above mentioned steps. 

Issue doesn't repro on playstore M55 & M56 builds. It is broken in M57. 

Tested on : Samsung Galaxy On Nxt  / MMB29K, Pixel XL / NDE63V 


Please find the log and screen record @ http://go/chrome-androidlogs1/6/670853


Wii provide bisect info soon. Thanks 
57.0.2931.0 - good build 
57.0.2933.0 - Bad build (57.0.2932.0 build is not available) 

https://chromium.googlesource.com/chromium/src/+log/57.0.2931.0..57.0.2933.0?pretty=fuller&n=10000

Will try to give exact CL for this bug tomorrow. Thanks 

Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
Bisect script pointed to:

https://chromium.googlesource.com/chromium/src/+/7ab964b30f73e3507ac3a424f56b1a9101b9bca3


Labels: hasbisect-per-revision ReleaseBlock-Stable

Comment 9 by bokan@chromium.org, Dec 14 2016

Labels: Hotlist-Input-Dev

Comment 10 by bokan@chromium.org, Dec 15 2016

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9f732d6fc99d6ddbff14333f17c0b5978e22322

commit f9f732d6fc99d6ddbff14333f17c0b5978e22322
Author: bokan <bokan@chromium.org>
Date: Thu Dec 22 22:34:27 2016

Invalidate LayoutView when the URL bar is hidden on short pages.

On a pages with no scrolling, hiding the top controls exposes a region beyond
the document rect. We need to invalidate this region so that we paint the
background into it.

This isn't a problem on scrollable pages because we simply reveal more of the
content layer. Short pages are revealing a region of nothingness.

In addition, I caught a mistake I made in a previous patch, in
https://codereview.chromium.org/2461463004. The width|heightChanged arguments
passed into setShouldDoFullPaintInvalidationOnResizeIfNeeded in
LayoutView::layout should compare against the layoutSize rather than the
visibleContentSize so I fixed the mistake.

BUG= 670853 

Review-Url: https://codereview.chromium.org/2575343004
Cr-Commit-Position: refs/heads/master@{#440527}

[modify] https://crrev.com/f9f732d6fc99d6ddbff14333f17c0b5978e22322/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/f9f732d6fc99d6ddbff14333f17c0b5978e22322/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/f9f732d6fc99d6ddbff14333f17c0b5978e22322/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Comment 12 by bokan@chromium.org, Dec 23 2016

Status: Fixed (was: Started)

Sign in to add a comment