New issue
Advanced search Search tips

Issue 670846 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 601332
issue 670843



Sign in to add a comment

13 tests in paint/invalidation/ are flaky when run in random order on Windows

Project Member Reported by jeffcarp@chromium.org, Dec 2 2016

Issue description

The tests:

paint/invalidation/multicol-with-abspos.html
paint/invalidation/selection-change-in-iframe-with-relative-parent.html
paint/invalidation/multicol-with-inline.html
paint/invalidation/textarea-set-disabled.html
paint/invalidation/multicol-with-abspos-in-relpos.html
paint/invalidation/table-hover-on-link.html
paint/invalidation/multicol-as-paint-container.html
paint/invalidation/paint-caret-in-div-with-negative-indent.html
paint/invalidation/multicol-with-text.html
paint/invalidation/multicol-with-block.html
paint/invalidation/inline-outline-repaint-2.html
paint/invalidation/inline-reflow.html
paint/invalidation/multicol-repaint.html

appear to be flaky when run in random order. Steps to reproduce:

This should pass consistently:
Tools/Scripts/run-layout-tests $TEST_DIRECTORY

This should fail intermittently:
Tools/Scripts/run-layout-tests $TEST_DIRECTORY --order=random

They failed in 11 out of 63 runs on the WebKit Win - RandomOrder builder. Here's an example of a build where they failed:
https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Win%20-%20RandomOrder/187

We're working on removing order dependency from Blink layout tests. More context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd78aa65a4005c59b09dedd8a45467e44227e896

commit bd78aa65a4005c59b09dedd8a45467e44227e896
Author: jeffcarp <jeffcarp@chromium.org>
Date: Sat Dec 03 00:44:57 2016

Add 13 Windows random order flaky tests

These tests were failing around 17% of the time on Windows.

BUG= 670846 
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2550733002
Cr-Commit-Position: refs/heads/master@{#436105}

[modify] https://crrev.com/bd78aa65a4005c59b09dedd8a45467e44227e896/third_party/WebKit/LayoutTests/RandomOrderExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119878b8b490d7767b873abf08efae940db67d6c

commit 119878b8b490d7767b873abf08efae940db67d6c
Author: mstensho <mstensho@opera.com>
Date: Fri Dec 09 01:47:20 2016

Hopefully deflake some tests, by preloading the Ahem font.

BUG= 670846 

Review-Url: https://codereview.chromium.org/2560073002
Cr-Commit-Position: refs/heads/master@{#437423}

[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/RandomOrderExpectations
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/inline-outline-repaint-2-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/inline-outline-repaint-2.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/inline-reflow-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/inline-reflow.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-as-paint-container-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-as-paint-container.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-repaint-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-repaint.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-abspos-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-abspos-in-relpos-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-abspos-in-relpos.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-abspos.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-block-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-block.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-inline-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-inline.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-text-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/multicol-with-text.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/paint-caret-in-div-with-negative-indent.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/resources/selection-change-in-iframe-with-relative-parent-iframe.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/table-hover-on-link.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/textarea-set-disabled-expected.html
[modify] https://crrev.com/119878b8b490d7767b873abf08efae940db67d6c/third_party/WebKit/LayoutTests/paint/invalidation/textarea-set-disabled.html

Status: Fixed (was: Untriaged)
I haven't seen these fail again so I'm going to mark this as fixed.

Sign in to add a comment