New issue
Advanced search Search tips

Issue 670845 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Incorrect Mouse Hit Test for Omnibox Indicators and text area

Project Member Reported by elawrence@chromium.org, Dec 2 2016

Issue description

Chrome Version: 57.0.2939.0
OS: Windows 10

What steps will reproduce the problem?

1. Open a page with a verbose security indicator, e.g. webdbg.com/test/intersection/rootisbody.html

2. Hover and click in the omnibox

Expect: Clicks on or to left of divider open page info bubble.
Expect: Clicks to right of divider focus text area.

Actual: Clicks slightly over the right of the divider open the page info bubble
Actual: Clicks up to 5 pixels to the right of the divider hit a "dead zone" where nothing happens.


 
ClickingRightOpensLeft.png
2.0 KB View Download
DeadZone.png
6.2 KB View Download
Status: Started (was: Assigned)
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf30a3650af3a96b865549ac8911f815b3e6f28a

commit cf30a3650af3a96b865549ac8911f815b3e6f28a
Author: spqchan <spqchan@chromium.org>
Date: Wed Nov 08 17:45:09 2017

[Mac] Fix Incorrect Hit Test with Omnibox Decorations

The extra divider padding causes a bug where the
you can click on the empty space beside the page info
decoration. This CL fixes it by removing the extra
space from the tracking area's frame.

Bug:  670845 
Change-Id: I763bdad530e83796aa28f64d8532cca39a5bdcb2
Reviewed-on: https://chromium-review.googlesource.com/757858
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514874}
[modify] https://crrev.com/cf30a3650af3a96b865549ac8911f815b3e6f28a/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/cf30a3650af3a96b865549ac8911f815b3e6f28a/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/cf30a3650af3a96b865549ac8911f815b3e6f28a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/cf30a3650af3a96b865549ac8911f815b3e6f28a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Labels: TE-Verified-64.0.3263.0 TE-Verified-M64
Tested the issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using chrome version 64.0.3263.0 by following the steps mentioned in the original comment and issue seems to be fixed.

Observed that when clicking on the left of the divider, the info bubble is opening and on clicking on the right of the divider, the focus is on the text area.
Attached screen cast for reference.

Hence adding TE-Verified Labels.

Thanks!

670845.webm
1.0 MB View Download

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Owner: ----
Status: Untriaged (was: Started)
Status: Verified (was: Untriaged)
This appears to have been fixed in #c3, and later verified, but not marked so. Please re-open if not fixed.

Sign in to add a comment