It has copies of these that talked to ui::Window. Now that ash is going to always use aura it should be possible to use the wm classes.
Issue 671418 has been merged into this issue.
I think not using ash's ShadowController in mash is partly to blame for 690546.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38dca0b349f34191c1a533d103b270d3571ce18d commit 38dca0b349f34191c1a533d103b270d3571ce18d Author: sky <sky@chromium.org> Date: Tue Feb 14 20:19:15 2017 chromeos: removes underlay surface offset It's no longer used. BUG= 670840 TEST=none R=mfomitchev@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2689283003 Cr-Commit-Position: refs/heads/master@{#450442} [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/services/ui/ws/window_tree.cc [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/services/ui/ws/window_tree.h [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/ui/aura/mus/window_manager_delegate.h [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/38dca0b349f34191c1a533d103b270d3571ce18d/ui/aura/mus/window_tree_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c328211dc652bed2edc3fb24858079b0e632ed5 commit 5c328211dc652bed2edc3fb24858079b0e632ed5 Author: sky <sky@chromium.org> Date: Tue Feb 14 22:01:38 2017 chromeos: removes mash shadows We're actually using the ash ones already. BUG= 670840 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2690363002 Cr-Commit-Position: refs/heads/master@{#450485} [modify] https://crrev.com/5c328211dc652bed2edc3fb24858079b0e632ed5/ash/mus/BUILD.gn [modify] https://crrev.com/5c328211dc652bed2edc3fb24858079b0e632ed5/ash/mus/non_client_frame_controller.cc [delete] https://crrev.com/1a2fcc1a4c4a40629e10b1a067004ace091ef341/ash/mus/shadow.cc [delete] https://crrev.com/1a2fcc1a4c4a40629e10b1a067004ace091ef341/ash/mus/shadow.h [delete] https://crrev.com/1a2fcc1a4c4a40629e10b1a067004ace091ef341/ash/mus/shadow_controller.cc [delete] https://crrev.com/1a2fcc1a4c4a40629e10b1a067004ace091ef341/ash/mus/shadow_controller.h [modify] https://crrev.com/5c328211dc652bed2edc3fb24858079b0e632ed5/ash/mus/window_manager.cc [modify] https://crrev.com/5c328211dc652bed2edc3fb24858079b0e632ed5/ash/mus/window_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f commit 5c71eb349c1b9f3e0624ad6f27ba0b09c666337f Author: sky <sky@chromium.org> Date: Wed Feb 15 19:39:25 2017 mash: wires up shadows for mash Specifically Widget::InitParams::shadow_type/shadow_elevation weren't plumbed through for DesktopWindowTreeHostMus. This meant the types weren't applied at to the aura::Window. They also weren't routed through the PropertyConverter. ShadowController is an EnvObserver. ShadowController runs both in mus and clients. Previously ShadowController keyed off new aura::Window creation to set the ShadowElevation property. This is problematic for the mus case as we want mus to make the decisions about shadows (unless a client has a specific requirement). To get this to work with mus I added a new shadow elevation type, DEFAULT, which means the shadow should be chosen based on the window type. ShadowController no longer sets the shadow type, instead it keys of the existing type and maps DEFAULT accordingly. This way mash sees DEFAULT and creates the right shadow. BUG= 690546 670840 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2694213003 Cr-Commit-Position: refs/heads/master@{#450775} [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ash/mus/window_manager.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter_unittest.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus_unittest.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/mus_client.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/native_widget_aura.h [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_controller.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_types.cc [modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_types.h
Comment 1 by sky@chromium.org
, Dec 12 2016