Legend float in fieldset makes legend disappear.
Reported by
txcuctec...@gmail.com,
Dec 2 2016
|
|||||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.75 Safari/537.36 Steps to reproduce the problem: 1. Have a fieldset with a legend tag. 2. Using CSS, set the legend to float: left or right. 3. Notice that there is no text where the legend should be. 4. Check any other browser and notice that the text shows up. What is the expected behavior? What went wrong? Nothing shows up on our enterprise web application where we have legends (which is all over every page). You can see the issue recreated on this jsbin: https://jsbin.com/zutekilusi/1/edit?html,css,output Did this work before? N/A Does this work in other browsers? Yes Chrome version: 55.0.2883.75 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0
Showing comments 10 - 109
of 109
Older ›
,
Dec 3 2016
It's safe to revert the patch. See https://codereview.chromium.org/2549973003/
,
Dec 3 2016
Issue 661230 has been merged into this issue.
,
Dec 3 2016
,
Dec 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f77a4ef8c0218492b5b8689a793b34b0f5a34d8 commit 0f77a4ef8c0218492b5b8689a793b34b0f5a34d8 Author: glebl <glebl@chromium.org> Date: Sun Dec 04 05:43:54 2016 Floating legend should be added to the fieldset's anonymous block. If fieldset's legend is floating it should be added to the existing fieldset\'s anonymous block instead of creating a nested one. This is necessary because flexbox forces the floating legend to be non-floating and therefore if the legend needs to be floating it should be added to the fieldset's anonymous block. BUG= 661230 , 670837 TEST=fast/forms/fieldset/fieldset-legend-float.html Tested with real world websites: https://jsbin.com/zutekilusi/1/edit?html,css,output http://www.timico.co.uk/timico-ltd-application-form http://codepen.io/michaelpumo/pen/VmZqrr https://en.wikipedia.org/wiki/Special:ActiveUsers https://jsfiddle.net/tdbthtra/ Review-Url: https://codereview.chromium.org/2550963002 Cr-Commit-Position: refs/heads/master@{#436187} [add] https://crrev.com/0f77a4ef8c0218492b5b8689a793b34b0f5a34d8/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html [add] https://crrev.com/0f77a4ef8c0218492b5b8689a793b34b0f5a34d8/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html [modify] https://crrev.com/0f77a4ef8c0218492b5b8689a793b34b0f5a34d8/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 4 2016
,
Dec 4 2016
,
Dec 4 2016
verified with URLs listed below using the last build revision #436193 downloaded from https://download-chromium.appspot.com/ https://jsbin.com/zutekilusi/1/edit?html,css,output http://www.timico.co.uk/timico-ltd-application-form http://codepen.io/michaelpumo/pen/VmZqrr https://en.wikipedia.org/wiki/Special:ActiveUsers https://jsfiddle.net/tdbthtra/
,
Dec 5 2016
[Automated comment] Less than a week to go before stable on M55, we might already have a stable candidate build. Manual review required.
,
Dec 5 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 5 2016
Verified the issue on Win 10.0,Ubuntu 14.04 & Mac 10.11.6 using chrome latest Canary M57-57.0.2942.0 by following steps mentioned in the original comment. Observed that legend value is displaying properly.Please find the screen shot for reference.Hence adding TE-Verified label. Thank You!
,
Dec 5 2016
Approving merge to M55 branch 2883 based on comment #16 and #19. Please merge ASAP. Thank you. Also please write a postmortem for this. Thank you again.
,
Dec 5 2016
After chatting with glebl@, we decided to wait until this change is fully baked in Canary (as Canary delivery was blocked due to bug 670999). Hence, removing "Merge-Approved-55" label and applying "Merge-Review-55" label. glebl@, please update the bug with Canary result. If all looks good, I will approve merge to M55. Thank you.
,
Dec 5 2016
Please note that the issue is no longer reproducible on https://en.wikipedia.org/wiki/Special:ActiveUsers at the moment, as we have deployed a workaround (https://phabricator.wikimedia.org/T151061).
,
Dec 5 2016
Issue 670783 has been merged into this issue.
,
Dec 5 2016
Issue 671303 has been merged into this issue.
,
Dec 5 2016
Please merge your change ASAP so that we could take it for next Release.
,
Dec 6 2016
I have clients with live eCommerce sites which are significantly affect by this issue. Shall we expect a fix or Chrome release soon, within the next day or two?
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eca396f71806b33ba869096ec28ae0d2c958b348 commit eca396f71806b33ba869096ec28ae0d2c958b348 Author: glebl <glebl@chromium.org> Date: Tue Dec 06 01:09:33 2016 Floating legend should be added to the fieldset's anonymous block. If fieldset's legend is floating it should be added to the existing fieldset\'s anonymous block instead of creating a nested one. This is necessary because flexbox forces the floating legend to be non-floating and therefore if the legend needs to be floating it should be added to the fieldset's anonymous block. BUG= 661230 , 670837 TEST=fast/forms/fieldset/fieldset-legend-float.html NOTRY=true NOPRESUBMIT=true Tested with real world websites: https://jsbin.com/zutekilusi/1/edit?html,css,output http://www.timico.co.uk/timico-ltd-application-form http://codepen.io/michaelpumo/pen/VmZqrr https://en.wikipedia.org/wiki/Special:ActiveUsers https://jsfiddle.net/tdbthtra/ Review-Url: https://codereview.chromium.org/2550963002 Review-Url: https://codereview.chromium.org/2552953002 Cr-Original-Commit-Position: refs/heads/master@{#436187} Cr-Commit-Position: refs/branch-heads/2924@{#352} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [add] https://crrev.com/eca396f71806b33ba869096ec28ae0d2c958b348/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html [add] https://crrev.com/eca396f71806b33ba869096ec28ae0d2c958b348/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html [modify] https://crrev.com/eca396f71806b33ba869096ec28ae0d2c958b348/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71ac9500f1ad978a5459991592c2d3a193b219d7 commit 71ac9500f1ad978a5459991592c2d3a193b219d7 Author: glebl <glebl@chromium.org> Date: Tue Dec 06 03:04:16 2016 Do not remove floating legend from inner block as it gets destroyed somewhere else. Do not remove floating from inner block as it gets destroyed in LayoutObject::destroyAndCleanupAnonymousWrappers. This patch fixes a clusterfuzz heap-use-after-free bugs. ClusterFuzz Detailed reports: https://cluster-fuzz.appspot.com/testcase?key=6339449719095296 https://cluster-fuzz.appspot.com/v2/testcase-detail/5132508879650816 BUG=671017, 670837 Review-Url: https://codereview.chromium.org/2552013002 Cr-Commit-Position: refs/heads/master@{#436504} [modify] https://crrev.com/71ac9500f1ad978a5459991592c2d3a193b219d7/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 6 2016
Cl listed at #28 didn't make it to latest Canary version 57.0.2943.0.
,
Dec 6 2016
This is not completely fixed yet, I am now able to see the legend however it is below the content instead of above it. I have attached screenshots from latest chrome version, Canary version and IE and you can see that it is still broken
,
Dec 6 2016
This broke thousands of sites. I've came across many sites having issues, and saw many 3rd party codes fixing this by replacing legend with div (all this under 1 day). I don't know your workflow, but in my opinion the cause of this should have been reverted and pushed to stable as it's a blocking issue!
,
Dec 6 2016
We have hundreds of thousands of users, many of which are using Chrome. This issue is causing complete breakage of our product across all versions. Any idea when a fix for this would be pushed into Chrome? Hours, days, weeks?
,
Dec 6 2016
Hey guys! I have the same problem! Please fix it, it's affecting the most of my forms.
,
Dec 6 2016
It’s still unbelievably that 55 was allowed to be released with a bug effecting so many sites despite it being reported on 1st of November (35 days ago) here https://bugs.chromium.org/p/chromium/issues/detail?id=661230
,
Dec 6 2016
chatted with ovidiupetruescu@gmail.com. He provided an example that still shows that fieldset doesn't work properly for his website. I'm reverting the change. I will update this bug a bit later today.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4b651adfd8d42052ee0c7967a18f6a29ba3524f commit d4b651adfd8d42052ee0c7967a18f6a29ba3524f Author: glebl <glebl@chromium.org> Date: Tue Dec 06 18:52:44 2016 Revert "Do not remove floating legend from inner block as it gets destroyed somewhere else." This reverts commit 71ac9500f1ad978a5459991592c2d3a193b219d7. Reason for revert: broke real world websites. BUG= 670837 Review-Url: https://codereview.chromium.org/2554813004 Cr-Commit-Position: refs/heads/master@{#436664} [modify] https://crrev.com/d4b651adfd8d42052ee0c7967a18f6a29ba3524f/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 6 2016
glebl@, please write a postmortem for this once this issue is fixed and merged to M55.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c commit f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c Author: glebl <glebl@chromium.org> Date: Tue Dec 06 21:18:30 2016 Revert "Floating legend should be added to the fieldset's anonymous block." This reverts commit 0f77a4ef8c0218492b5b8689a793b34b0f5a34d8. Reason for revert: broke real world websites BUG= 670837 Review-Url: https://codereview.chromium.org/2552373002 Cr-Commit-Position: refs/heads/master@{#436729} [delete] https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html [delete] https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html [modify] https://crrev.com/f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 7 2016
,
Dec 7 2016
And today Chrome 55 drops for Android, with the bug. :rollseyes:
,
Dec 7 2016
+ Alex (PTAL comment #40)
,
Dec 7 2016
Hi - thank you for addressing this issue. Can you provide a ballpark time frame for getting this patch released? We are trying to decide whether to apply a workaround, or wait for your fix and provide a message to users to update their browsers. Management is having a bit of a hard time understanding the severity of the issue, because not all of our users use Chrome, not everyone will have updated, and it's clear that you're working on it. I'm not looking for a firm commitment on release date, just a ballpark. If you're coming out with this fix tomorrow, then we'll probably wait. If there's no way your workflow will allow the patch to come out before next week at the earliest, for example, then we would probably apply the workaround. Thanks!
,
Dec 7 2016
I am fighting the problem on ChromeOS. Currently on: Version 55.0.2883.82 beta (64-bit) Platform 8872.67.0 (Official Build) beta-channel auron_yuna ARC Version 3540309 Firmware Google_Auron_yuna.6301.59.8 #CBC-RS/TC-watchlist
,
Dec 7 2016
I would also appreciate a ballpark time frame if you could. We will need to move on this fast if the publication of a patch would be too far in the future. Thank you
,
Dec 7 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a34c8753d57bdcf88b27e6df780877880820603 commit 9a34c8753d57bdcf88b27e6df780877880820603 Author: glebl <glebl@chromium.org> Date: Wed Dec 07 17:33:51 2016 Revert commit# 415577 "Add grid/flex layout support for <fieldset>" This patch partially reverts crrev.com/415577. Reason for revert: Broke real world websites. BUG= 670837 Review-Url: https://codereview.chromium.org/2549973003 Cr-Commit-Position: refs/heads/master@{#436992} [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/b76c8a01635602eff06757e4fcbedf0b8743fc52/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html [delete] https://crrev.com/b76c8a01635602eff06757e4fcbedf0b8743fc52/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html [delete] https://crrev.com/b76c8a01635602eff06757e4fcbedf0b8743fc52/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html [delete] https://crrev.com/b76c8a01635602eff06757e4fcbedf0b8743fc52/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutFieldset.h [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h [modify] https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Dec 7 2016
the fix will be available on Chrome Canary - tomorrow Chrome Stable - early next week
,
Dec 7 2016
Great! Thanks for the update.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e319e60474b1842ed11653ffe4b5d443a21ebac5 commit e319e60474b1842ed11653ffe4b5d443a21ebac5 Author: Gleb Lanbin <glebl@chromium.org> Date: Wed Dec 07 18:44:56 2016 Revert "Floating legend should be added to the fieldset's anonymous block." This reverts commit 0f77a4ef8c0218492b5b8689a793b34b0f5a34d8. Reason for revert: broke real world websites BUG= 670837 Review-Url: https://codereview.chromium.org/2552373002 Cr-Commit-Position: refs/heads/master@{#436729} (cherry picked from commit f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c) Review URL: https://codereview.chromium.org/2560913002 . Cr-Commit-Position: refs/branch-heads/2924@{#383} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [delete] https://crrev.com/2a9c08187549b97a87b0b43c3f9f825816fdf334/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html [delete] https://crrev.com/2a9c08187549b97a87b0b43c3f9f825816fdf334/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html [modify] https://crrev.com/e319e60474b1842ed11653ffe4b5d443a21ebac5/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp
,
Dec 7 2016
,
Dec 7 2016
Any chance we can get the fix merged to 55 Chrome today? Chrome OS has not published stable on 55 yet, and we are holding back for this, but would like to try to get a release candidate built overnight.
,
Dec 7 2016
Changes are not baked/verified in Canary yet that is the reason M55 merge is not approved yet.
,
Dec 7 2016
When do we think we can get the first build of 55 Chrome with the fix? (independent of when the browser is pushed on non CrOS platforms)
,
Dec 7 2016
I can trigger M55 build tomorrow as soon as change is merged to M55 after Canary verification.
,
Dec 7 2016
I spoke with bthompson@ and govind@ - we are going to approve the merge now so that we can kick a build for CrOS and test overnight. However, no one should ship M55 to stable with this patch included until we have a chance to review crash rates / hear back from users on this bug based on tonight's canary build. Merge approved for M55 branch 2883; I will also approve for M56 branch 2924 but let's not process that until we have confirmation that everything looks good tomorrow.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1707000b18468db81dc63536da511d1b2964ce8d commit 1707000b18468db81dc63536da511d1b2964ce8d Author: Gleb Lanbin <glebl@chromium.org> Date: Thu Dec 08 00:57:54 2016 Revert commit# 415577 "Add grid/flex layout support for <fieldset>" This patch partially reverts crrev.com/415577. Reason for revert: Broke real world websites. BUG= 670837 NOTRY=true NOPRESUBMIT=true R=ikilpatrick@chromium.org Review URL: https://codereview.chromium.org/2555413002 . Review-Url: https://codereview.chromium.org/2549973003 Cr-Original-Commit-Position: refs/heads/master@{#436992} Cr-Commit-Position: refs/branch-heads/2883@{#720} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/378d64878a6c9d888385ab87797351a3d1612a68/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html [delete] https://crrev.com/378d64878a6c9d888385ab87797351a3d1612a68/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html [delete] https://crrev.com/378d64878a6c9d888385ab87797351a3d1612a68/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html [delete] https://crrev.com/378d64878a6c9d888385ab87797351a3d1612a68/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutFieldset.h [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h [modify] https://crrev.com/1707000b18468db81dc63536da511d1b2964ce8d/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3 commit fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3 Author: glebl <glebl@chromium.org> Date: Thu Dec 08 01:53:09 2016 Rebaseline crrev.com/436992 layout tests. BUG= 670837 Review-Url: https://codereview.chromium.org/2555933003 Cr-Commit-Position: refs/heads/master@{#437130} [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/css/fieldset-display-row-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/006-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/007-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/fieldset-legend-padding-unclipped-fieldset-border-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/fieldset-with-float-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/float-before-fieldset-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/ruby/rubyDOM-remove-text2-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/fieldsets-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/linux/svg/custom/inline-svg-in-xhtml-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/inline-svg-in-xhtml-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/inline-svg-in-xhtml-expected.txt [delete] https://crrev.com/80166859e901cfd6e3674dab1680bcf8c5cdb758/third_party/WebKit/LayoutTests/platform/mac-retina/fast/block/basic/fieldset-stretch-to-legend-expected.png [delete] https://crrev.com/80166859e901cfd6e3674dab1680bcf8c5cdb758/third_party/WebKit/LayoutTests/platform/mac-retina/fast/borders/fieldsetBorderRadius-expected.png [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/css/fieldset-display-row-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/006-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/007-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/fieldset-legend-padding-unclipped-fieldset-border-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/fieldset-with-float-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/float-before-fieldset-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/fieldsets-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/css/fieldset-display-row-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/006-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/007-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/fieldset-legend-padding-unclipped-fieldset-border-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/fieldset-with-float-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/float-before-fieldset-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/fieldsets-expected.txt [modify] https://crrev.com/fde3d4da279ba4ac4b1e33e74b5dc794bed9e8b3/third_party/WebKit/LayoutTests/platform/win/svg/custom/inline-svg-in-xhtml-expected.txt
,
Dec 8 2016
Rechecked this issue on chrome version 55.0.2883.87 on Windows 10, MAC 10.12.1, Ubuntu 14.04 using the below test URL's: 1) https://jsbin.com/zutekilusi/1/edit?html,css,output 2) https://jsfiddle.net/tdbthtra/ 3) http://codepen.io/michaelpumo/pen/VmZqrr For the first and second URL's the expected output is displayed as required, screenshots attached. For the Third URL: The expected output varies. Screen shot attached with a comparison with Firefox. Kindly have a review of it and let us know if this is intended. Based on the comments will add TE-Verified labels. Thanks.!
,
Dec 8 2016
,
Dec 8 2016
Issue 672401 has been merged into this issue.
,
Dec 8 2016
Just to update, same behavior as mentioned in comment 59 is observed on Canary build 57.0.2945.0 on Windows 10 and Ubuntu 14.04 and for Build 57.0.2945.3 on MAC 10.12.1 Thanks.!
,
Dec 8 2016
Just to report that 57.0.2945.0 canary (64-bit) on Win10 correctly displays http://www.timico.co.uk/timico-ltd-application-form
,
Dec 8 2016
Subscribe to this issue. After update I see this problem on your site. https://bugs.chromium.org/p/chromium/issues/detail?id=670837#c59
,
Dec 8 2016
re: #59 N3(http://codepen.io/michaelpumo/pen/VmZqrr). yes. It's expected. Please see the attached screenshot from Chrome M44. You may notice that it looks broken comparing to the screenshot from M55 with the fix. This is because we fixed http://crbug.com/481983 in this release. So the current behavior is closer to Firefox and other browsers.
,
Dec 8 2016
Thanks for the update, Adding TE-Verified labels as per above comments.
,
Dec 8 2016
I am not having the problem anymore on Version 57.0.2945.1 (Official Build) canary SyzyASan (32-bit). Seems to be fixed.
,
Dec 8 2016
Our problems are also resolved in Canary 57.0.2945.1. Thanks!
,
Dec 8 2016
Canary 57.0.2945.1 is working for us as well.
,
Dec 8 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 8 2016
Issue 672491 has been merged into this issue.
,
Dec 8 2016
This breaks AdWords. Can we please revert to M54 until M55 is fixed?
,
Dec 8 2016
Is the ETA still "early next week"??
,
Dec 8 2016
Issue 672321 has been merged into this issue.
,
Dec 9 2016
***BULK EDIT*** Your change has been approved for M56. Please ensure to verify the fix and merge ASAP so that we could take it for next Beta Release. If the change is already merged and no pending work please remove Merge-Approved-56 label and add merge-merged-2924.
,
Dec 9 2016
re: #75 per #56 I'm waiting for amineer@ approval to merge this into M56.
,
Dec 9 2016
Approving merge to M56 per chat with amineer@.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/712f272a9cce2a62b9a3063a521337a7551be17e commit 712f272a9cce2a62b9a3063a521337a7551be17e Author: Gleb Lanbin <glebl@chromium.org> Date: Fri Dec 09 04:58:50 2016 Revert commit# 415577 "Add grid/flex layout support for <fieldset>" This patch partially reverts crrev.com/415577. Reason for revert: Broke real world websites. BUG= 670837 Review-Url: https://codereview.chromium.org/2549973003 Review-Url: https://codereview.chromium.org/2560123003 . Cr-Original-Commit-Position: refs/heads/master@{#436992} Cr-Commit-Position: refs/branch-heads/2924@{#426} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [delete] https://crrev.com/57e2b1dde8ef3b0a364258f4b07cd753b2cf4b38/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html [delete] https://crrev.com/57e2b1dde8ef3b0a364258f4b07cd753b2cf4b38/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html [delete] https://crrev.com/57e2b1dde8ef3b0a364258f4b07cd753b2cf4b38/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html [delete] https://crrev.com/57e2b1dde8ef3b0a364258f4b07cd753b2cf4b38/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutFieldset.h [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h [modify] https://crrev.com/712f272a9cce2a62b9a3063a521337a7551be17e/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Dec 9 2016
Verified (canary 57.0.2945.0): fixed issue 672321 : CapitalOne Add External Account bug. Question text is now displayed. Thanks glebl for merging 672321 here.
,
Dec 9 2016
Is this still planned as an M55 bug fix release early next week? I'm concerned about the remark above saying that it broke AdWords and requesting to revert to M54. As before, I'm just trying to keep management apprised of the situation. Thanks!
,
Dec 9 2016
This patch is now pushing out to stable channel in version 55.0.288.87 for Windows and Mac. Linux update will be next week.
,
Dec 9 2016
Verified patch for cr 672321 OK in stable 55.0.2283.87. Still failing in today's 12/9 beta updt 56.0.2924.21 Canary 12/9 57.0.2946.0 still OK Needs a m56 merge too?
,
Dec 9 2016
55.0.2883.91 is being submitted to the Play Store now for Android, which will fix the issue there. larrylaca818@, this has already been merged to M56 (see c#78), but it just missed the cut for the build you are referring to. It will be fixed in M56 beta next week. I am going to mark this bug as fixed since the patch has landed on all applicable branches (M55, M56, trunk) and has been deployed broadly - once Android pushes, only Linux M55 will be pending, and that will be addressed Monday. Please reopen if anyone sees further issues on builds .87 (for desktop) or .91 (for Android). We'll put together a postmortem to help us avoid issues like this in the future, and on behalf of the team I apologize for the inconvenience this has caused. Thanks to everyone who reported this, as well as to everyone who assisted in testing - we greatly appreciate your help.
,
Dec 9 2016
Looks great. Thanks for fixing it quickly!
,
Dec 10 2016
Re: (unofficial) postmortem: Earliest issue merged here (670837) is issue 661230 , opened 11/1 for beta 55.0.2883.28 and identified as a 'legend' issue at that time. This was +2 weeks into the m55 beta cycle. Bisect and assignment followed on 11/16. By this time m55 stable was only 2 weeks away, with an intervening holiday. I don't see much in 661230 to expose the significant impact the bug would have when it reached stable on 12/1. The fix was made 12/4, within 3 days of reaching stable, appeared in canary 12/8 (57.0.2945.0) and was merged into stable 55.0.2883.87, released today 12/9. (Dates and releases are for Win10 platform, PST) IMHO: From fix to stable release was snappy. Response from first appearance to assignment was only 2 weeks, again good, and from assignment to fix another 2 weeks, not bad either. What would have helped is getting more commercial sector involvement in beta so that the looming impact could have been know earlier.
,
Dec 11 2016
glebl@ - Thanks for pulling this together in the last hours for stable. re: postmortem: The bug could have been seen as early as 9/2 (55.0.2846.0 canary), but didn't show up as a CR until 11/1. If you could find a way to send me your postmortem, I'd appreciate it. I'm on G+ and my email isn't hard to track down. Just general curiosity about all things Chrome and how this big pot keeps cooking
,
Dec 12 2016
Hello team, 55.0.2883.91 is being submitted to the Play Store now for Android. Thanks for that. we are waiting for win7 fixes.
,
Dec 12 2016
#88 - why are you waiting? Update Chrome (go to chrome:chrome, or to About Google Chrome in the Chrome menu, under Help).
,
Dec 12 2016
Can you share the postmortem with me as well?
,
Dec 12 2016
When we are expecting a solution for windows 7 ? Any Idea ?
,
Dec 12 2016
Naresh, did you see comment #89? Windows 7 should be fixed. Did you update Chrome?
,
Dec 12 2016
Rajib, for me Chrome on Android is still 54 and the Play store doesn't offer me an update. Chrome Beta on Android is 55 and is still broken. Play store also doesn't offer me an update for Chrome Beta. Is this expected?
,
Dec 12 2016
#93 - updates are gradual, wait a few days and it should offer an update. Please, share the post mortem publicly instead of sharing it with specific individuals. :)
,
Dec 12 2016
For me I am still getting issue on chrome version 55 and windows version 7.
,
Dec 12 2016
comment # 92 - Thanks issue has been resolved for me when I update my chrome .
,
Dec 12 2016
Issue 668699 has been merged into this issue.
,
Dec 12 2016
,
Dec 12 2016
,
Dec 12 2016
Issue 673272 looks like a dup
,
Dec 13 2016
Issue 672487 has been merged into this issue.
,
Dec 13 2016
Should Linux have been fixed on Monday? I'm still seeing this on Linux.
,
Dec 13 2016
#102 - Looks like Linux was also pushed - https://googlechromereleases.blogspot.co.il/2016/12/stable-channel-update-for-desktop_9.html - so just make sure your Chrome is up to date. The version should be 55.0.2883.87.
,
Dec 13 2016
Yeah, that blog post is misleading. Linux was pushed yesterday, according to https://omahaproxy.appspot.com/ Anyway, make sure you update your Chrome.
,
Dec 13 2016
I had checked chrome://help and it didn't tell me there was an update or that I had to reboot, but after rebooting it's indeed fixed.
,
Dec 14 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 56.0.2924.28 with the URL http://codepen.io/michaelpumo/pen/VmZqrr. Observed the expected output as per the comment #65. Please find the attached screen shot for the same. Adding TE-Verified labels. Thanks,
,
Jan 18 2017
Has the postmortem been made available?
,
Feb 21 2018
Border still wasn't showing in v64. Added it to fieldset and legend with css (included radius) and it appears again.
Showing comments 10 - 109
of 109
Older ›
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
