New issue
Advanced search Search tips

Issue 670825 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove extension_misc::IsImeMenuExtensionId if not needed.

Project Member Reported by msw@chromium.org, Dec 2 2016

Issue description

Remove extension_misc::IsImeMenuExtensionId if not needed.

This function seems to have been used for removed Chrome OS IME panel code. Came up here:
https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/launcher/launcher_item_controller.cc#oldcode26
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9993de07cfd0de4f5ad4f682798c84f1d071e38

commit d9993de07cfd0de4f5ad4f682798c84f1d071e38
Author: azurewei <azurewei@chromium.org>
Date: Wed Dec 14 01:38:20 2016

Remove extension_misc::IsImeMenuExtensionId.

extension_misc::IsImeMenuExtensionId() is added for some opt-in IME menu specific logic, since we used to used IME extensions to show the menu:

1) extension_launcher_context_menu.cc: Remove close button from context menu (see issue 1611463002).
2) chrome_native_app_window_views.cc: Move IME menu from mru list (see issue 2025263002).

Since we have abandoned the way of using IME extensions to show IME menu, all these codes could be removed.

BUG= 670825 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2563343002
Cr-Commit-Position: refs/heads/master@{#438382}

[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/aura/wm_window_aura.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm/mru_window_tracker.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm/window_state.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm/window_state.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm_window.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ash/common/wm_window_property.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/chrome/common/extensions/extension_constants.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ui/aura/client/aura_constants.h
[modify] https://crrev.com/d9993de07cfd0de4f5ad4f682798c84f1d071e38/ui/aura/mus/property_converter.cc

Status: Fixed (was: Assigned)
Labels: M-57

Sign in to add a comment