New issue
Advanced search Search tips

Issue 670820 link

Starred by 1 user
Status: Verified
Owner:
zmin@chromium.org
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Check Failed when launching chrome with a supervised user when force sign in is enabled

Project Member Reported by zmin@chromium.org, Dec 2 2016 
Chrome Version: M57

What steps will reproduce the problem?
(1) Launch Chrome, Create a SU, close Chrome, make sure SU is the last used profile.
(2) Enable Force Signin
(3) Launch Chrome again

What is the expected result?
Because SU is not able to be signed in, UserManager should be shown.

What happens instead?
Check failed: profile_manager.cc(1313): Check failed: !GetProfileByPathInternal(profile_dir)

Comment 1 by zmin@chromium.org, Dec 2 2016 

When Chrome is launch with a SU user, the profile of SU will be created with prefs::kIsSigninAllowed set to false by default:
https://cs.chromium.org/chromium/src/chrome/browser/supervised_user/supervised_user_pref_store.cc?q=prefs::kSigninAllowed,+file:%5Esrc/chrome/browser/supervised_user/&sq=package:chromium&l=121&dr=C

It will trigger the OnSigninAllowedPrefChanged in SigninManager which ends up with a sign out event regardless:
https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_manager.cc?q=OnSigninAllowedPrefChanged+file:%5Esrc/components/signin/core/browser/&sq=package:chromium&l=271&dr=CSs

When force-sign-in is enabled, the UserManager will be opened once the sign out event is finished.

In the mean time, because force-sign-in is enabled, the SU profile will be locked so the startup process will also try to show the UserManager because the last used profile is not useable.

So there are two places try to create the System Profile and show the UserManager together, and the second one will ends up with the CHECK failure here:
https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_manager.cc?type=cs&q=CHECK%5C(!GetProfileByPathInternal%5C(profile_dir%5C)%5C)+file:%5Esrc/chrome/browser/profiles/&sq=package:chromium&l=1304
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea202a58ee2c14f187d219922721fe5d6bf95fc

commit 4ea202a58ee2c14f187d219922721fe5d6bf95fc
Author: zmin <zmin@chromium.org>
Date: Mon Dec 05 18:49:01 2016

Fix Check failure in ProfileManager when force-sign-in is enabled and last used profile is supervised user

BUG= 670820 
BUG= 642059 

Review-Url: https://codereview.chromium.org/2547083004
Cr-Commit-Position: refs/heads/master@{#436365}

[modify] https://crrev.com/4ea202a58ee2c14f187d219922721fe5d6bf95fc/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/4ea202a58ee2c14f187d219922721fe5d6bf95fc/components/signin/core/browser/signin_manager.cc

Comment 3 by zmin@chromium.org, Dec 12 2016

Status: Verified (was: Started)
Verified with 57.0.2949.0 canary on Win 10
►

Sign in to add a comment