Issue 670814 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	bashi@chromium.org
Closed:	Dec 2016
Components:	Internals Tests>Missing
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	1
Type:	Bug-Regression
ReleaseBlock-Stable M-57

[Missing Tests]: memory coordinator: Check RenderProcessHost pointers before use them.

Project Member Reported by manoranj...@chromium.org, Dec 2 2016

Issue description

bashi@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2536533002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=668924

Thank you!

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8

commit 55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8
Author: bashi <bashi@chromium.org>
Date: Mon Dec 05 01:43:03 2016

Add tests for MemoryCoordinator::Can{Throttle,Suspend}Renderer()

This is a follow-up CL of crrev.com/2536533002.

BUG= 670814 

Review-Url: https://codereview.chromium.org/2552603002
Cr-Commit-Position: refs/heads/master@{#436212}

[modify] https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8/content/browser/memory/memory_coordinator.cc
[modify] https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8/content/browser/memory/memory_coordinator.h
[modify] https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8/content/browser/memory/memory_coordinator_browsertest.cc
[modify] https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8/content/browser/memory/memory_coordinator_unittest.cc

Comment 2 by bashi@chromium.org, Dec 5 2016

Status: Fixed (was: Assigned)

Comment 3 by manoranj...@chromium.org, Dec 5 2016

Thank you so much for your time adding this automated test.

►

Issue 670814 link

Issue metadata

[Missing Tests]: memory coordinator: Check RenderProcessHost pointers before use them.

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

Comment 1 Deleted

Comment 2 by bashi@chromium.org, Dec 5 2016

Comment 2 Deleted

Comment 3 by manoranj...@chromium.org, Dec 5 2016

Comment 3 Deleted

Sign in to add a comment