New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670810 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Dec 21
Cc:
█ kqyang@chromium.org
ddorwin@chromium.org
chcunningham@chromium.org
wolenetz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Validate container and codec string in 1 (or fewer) easy to maintain place(s)

Project Member Reported by wolenetz@chromium.org, Dec 2 2016 
For src= vs MSE, multiple overlapping checks are done in multiple places.

See also https://codereview.chromium.org/2495193004/diff/140001/media/base/video_codecs.cc#newcode371

This bug tracks investigating and making this cleaner.

Comment 1 by wolenetz@chromium.org, Dec 2 2016 

A first step might be to pass in the container to the new method in https://codereview.chromium.org/2495193004/diff/140001/media/base/video_codecs.cc#newcode371

Though I think in longer term, the issue is more general: MSE and src= mime/codec checks overlap and can be hard to maintain.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by wolenetz@chromium.org, Dec 11 2017

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by wolenetz@chromium.org, Dec 21

Status: WontFix (was: Untriaged)
The code state is slowly improving. More recent work chcunningham@ has been doing around MCAPI-related mime validations has more recent context, so closing this one.
►

Sign in to add a comment