WebVR: Crash when exiting presentation |
|||||||
Issue descriptionWhen stress testing WebVR presentation enter and exit flow on ToT Chrome (57.0.2940.0) I managed to crash chrome while exiting VR presentation mode. Stack below: 12-02 10:42:45.621 26876 26876 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 12-02 10:42:45.621 26876 26876 F DEBUG : Build fingerprint: 'google/marlin/marlin:7.1/NME60B/3231051:userdebug/dev-keys' 12-02 10:42:45.621 26876 26876 F DEBUG : Revision: '0' 12-02 10:42:45.621 26876 26876 F DEBUG : ABI: 'arm' 12-02 10:42:45.621 26876 26876 F DEBUG : pid: 19362, tid: 19362, name: chromium.chrome >>> org.chromium.chrome <<< 12-02 10:42:45.621 26876 26876 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 12-02 10:42:45.621 26876 26876 F DEBUG : r0 00000000 r1 ca7d32a0 r2 effee2f4 r3 00000080 12-02 10:42:45.621 26876 26876 F DEBUG : r4 c6d5ad80 r5 00000000 r6 c5cae2c8 r7 c6acb620 12-02 10:42:45.622 26876 26876 F DEBUG : r8 00000000 r9 ff9e81bc sl c71e1fbc fp c71e1fd8 12-02 10:42:45.622 26876 26876 F DEBUG : ip effe4948 sp ff9e81b8 lr d4ec7d23 pc d4ec7d26 cpsr 60070030 12-02 10:42:45.626 26876 26876 F DEBUG : 12-02 10:42:45.626 26876 26876 F DEBUG : backtrace: 12-02 10:42:45.629 26876 26876 F DEBUG : #00 pc 00010d26 /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so (_ZN6device8VRDevice9OnChangedEv+55) 12-02 10:42:45.629 26876 26876 F DEBUG : #01 pc 00014dc5 /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so (_ZN6device17GvrDeviceProvider29SwitchToNonPresentingDelegateEv+84) 12-02 10:42:45.629 26876 26876 F DEBUG : #02 pc 00014d59 /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so (_ZN6device17GvrDeviceProvider11ExitPresentEv+2) 12-02 10:42:45.629 26876 26876 F DEBUG : #03 pc 0001493b /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so 12-02 10:42:45.629 26876 26876 F DEBUG : #04 pc 00010cb3 /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so (_ZN6device8VRDevice13RemoveServiceEPNS_13VRServiceImplE+26) 12-02 10:42:45.630 26876 26876 F DEBUG : #05 pc 00011e4d /data/app/org.chromium.chrome-2/lib/arm/libdevice_vr.cr.so 12-02 10:42:45.630 26876 26876 F DEBUG : #06 pc 00012b55 /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo23InterfaceEndpointClient11NotifyErrorEv+68) 12-02 10:42:45.630 26876 26876 F DEBUG : #07 pc 00015553 /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo8internal15MultiplexRouter22ProcessNotifyErrorTaskEPNS1_4TaskENS1_18ClientCallBehaviorEPN4base22SingleThreadTaskRunnerE+52) 12-02 10:42:45.630 26876 26876 F DEBUG : #08 pc 00014b09 /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo8internal15MultiplexRouter12ProcessTasksENS1_18ClientCallBehaviorEPN4base22SingleThreadTaskRunnerE+110) 12-02 10:42:45.630 26876 26876 F DEBUG : #09 pc 0001437d /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo8internal15MultiplexRouter21OnPipeConnectionErrorEv+208) 12-02 10:42:45.630 26876 26876 F DEBUG : #10 pc 00010ec3 /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo9Connector11HandleErrorEbb+152) 12-02 10:42:45.630 26876 26876 F DEBUG : #11 pc 00010fdd /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo9Connector17ReadSingleMessageEPj+160) 12-02 10:42:45.630 26876 26876 F DEBUG : #12 pc 000111b1 /data/app/org.chromium.chrome-2/lib/arm/libbindings.cr.so (_ZN4mojo9Connector21OnHandleReadyInternalEj+42) 12-02 10:42:45.630 26876 26876 F DEBUG : #13 pc 00002e9d /data/app/org.chromium.chrome-2/lib/arm/libmojo_public_system_cpp.cr.so (_ZN4mojo7Watcher13OnHandleReadyEj+44) 12-02 10:42:45.630 26876 26876 F DEBUG : #14 pc 0007f58d /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (_ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE+136) 12-02 10:42:45.630 26876 26876 F DEBUG : #15 pc 00094c31 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (_ZN4base11MessageLoop7RunTaskEPNS_11PendingTaskE+304) 12-02 10:42:45.630 26876 26876 F DEBUG : #16 pc 00094e81 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (_ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE+28) 12-02 10:42:45.630 26876 26876 F DEBUG : #17 pc 0009511f /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (_ZN4base11MessageLoop6DoWorkEv+246) 12-02 10:42:45.630 26876 26876 F DEBUG : #18 pc 00095b9b /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (Java_org_chromium_base_SystemMessageHandler_nativeDoRunLoopOnce+18) 12-02 10:42:45.630 26876 26876 F DEBUG : #19 pc 0065bbdd /data/app/org.chromium.chrome-2/oat/arm/base.odex (offset 0x62d000)
,
Dec 2 2016
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b771fd8575223a45d6493dca6267d2198a0db499 commit b771fd8575223a45d6493dca6267d2198a0db499 Author: bajones <bajones@chromium.org> Date: Fri Dec 02 21:08:12 2016 Prevent new events from being sent to WebVR pages that are being closed. BUG= 670802 Review-Url: https://codereview.chromium.org/2547923003 Cr-Commit-Position: refs/heads/master@{#436013} [modify] https://crrev.com/b771fd8575223a45d6493dca6267d2198a0db499/device/vr/vr_device.cc
,
Dec 2 2016
,
Dec 2 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b504160c0fc4577a2741447a0c584b50bf6d0b commit e7b504160c0fc4577a2741447a0c584b50bf6d0b Author: Brandon Jones <bajones@chromium.org> Date: Fri Dec 02 21:54:32 2016 Prevent new events from being sent to WebVR pages that are being closed. BUG= 670802 Review-Url: https://codereview.chromium.org/2547923003 Cr-Commit-Position: refs/heads/master@{#436013} (cherry picked from commit b771fd8575223a45d6493dca6267d2198a0db499) Review URL: https://codereview.chromium.org/2548893002 . Cr-Commit-Position: refs/branch-heads/2924@{#303} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e7b504160c0fc4577a2741447a0c584b50bf6d0b/device/vr/vr_device.cc
,
Jan 7 2017
This M56 stable blocker is still open. Does the merge above address it?
,
Jan 8 2017
I haven't been able to trigger this recently, so I'm going to presume the above CL has indeed fixed it unless someone else has run into it.
,
Jul 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ddorwin@chromium.org
, Dec 2 2016