Issue 670801 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	msw@chromium.org
Closed:	Dec 2016
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Proj-Mustash-Mash VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 670798

Ash shouldn't connect to chrome for ash::mojom::WallpaperManager

Project Member Reported by jamescook@chromium.org, Dec 2 2016

Issue description

Instead of ash connecting to chrome have chrome set the client interface on ash on startup (which it can then use at any point). This enforces the proper layering. 

See https://codereview.chromium.org/2525813004/ for a similar change.

Comment 1 by jamescook@chromium.org, Dec 2 2016

Blocking: 670798

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e6bcece082c7a57af4a436fe7599770543140a2

commit 6e6bcece082c7a57af4a436fe7599770543140a2
Author: msw <msw@chromium.org>
Date: Thu Dec 08 01:29:50 2016

mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG= 670801 
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,

Review-Url: https://codereview.chromium.org/2559503003
Cr-Commit-Position: refs/heads/master@{#437116}

[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/ash/common/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/ash/common/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/chrome/browser/chromeos/chrome_interface_factory.cc
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h