Ash shouldn't connect to chrome directly |
|||||||
Issue description
This is a tracking bug.
In particular, it shouldn't do ConnectToInterface("content_browser", &interface_ptr). Ash knowing about chrome/content_browser is a layering violation.
One goal of mustash is to make ash be able to run without chrome. In most cases we can have chrome call an ash::mojom::FooInterface::SetClient() method to set itself as the client.
Code in ash can just check if its client interface pointer is bound. For example:
if (foo_interface_client_)
foo_interface_client_->DoBar();
See SystemTrayController / SystemTrayClient for an example.
See blocked-on bugs for things we need to fix.
,
Dec 9 2016
Should we have more blocked-on bugs for KeyboardUIService? (I'm guessing mash::mojom::Launchable is okay as-is...)
,
Dec 9 2016
Adding more specific bugs SGTM.
,
Dec 9 2016
,
Jan 23 2017
Moving to fixed as all blockers have now been fixed.
,
Jan 23 2017
Does ash/BUILD.gn still need a dep on content/public/common:service_names? https://cs.chromium.org/chromium/src/ash/BUILD.gn?type=cs&q=src/ash/BUILD.gn&sq=package:chromium&l=862
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ba6bc624e1a29ebe9fa66c36cc96e16224c858a commit 2ba6bc624e1a29ebe9fa66c36cc96e16224c858a Author: sky <sky@chromium.org> Date: Mon Jan 23 20:35:25 2017 ash: removes unnecessary includes and dep BUG= 670798 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2652763002 Cr-Commit-Position: refs/heads/master@{#445470} [modify] https://crrev.com/2ba6bc624e1a29ebe9fa66c36cc96e16224c858a/ash/BUILD.gn [modify] https://crrev.com/2ba6bc624e1a29ebe9fa66c36cc96e16224c858a/ash/common/cast_config_controller.cc
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Feb 26 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jamescook@chromium.org
, Dec 2 2016