New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670797 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

User expectations are no longer working on Chrome ref build

Project Member Reported by charliea@chromium.org, Dec 2 2016

Issue description

For some reason, it seems like user expectations have been broken on the ref build since about 11/30.

See: ref_build_stoppage.png.

Given that this is the ref build and not ToT, there are a couple of possibilities that I see, each of which I'll address separately:

### The reference build was updated ###

Nope. The last reference build update was on 10/11, long before the stoppage. https://cs.corp.google.com/github/catapult-project/catapult/common/py_utils/py_utils/chrome_binaries.json?q=p:github+f:%5Ecatapult-project/catapult/+chrome_binaries.json&dr

### The stoppage was caused by a Javascript-side Catapult change ###

Nope. The changelog from the first broken build (https://chromium.googlesource.com/chromium/src/+log/679ce83f762e4774b5721704257baa5e71119baa%5E..3b5e1a345a490034e4588ce4e512bfa10de413f3?pretty=fuller) shows only one Catapult roll, containing two CLs: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b38578d92404..59c9c1d73830

Neither CL seems remotely related to metrics.

### The stoppage was caused by a benchmark or infrastructure change ###

Possibly: searching for "tools/perf" in the changelog only yields one changelist that *might* be related: https://codereview.chromium.org/2540213002. That changelist enabled swarming on the Mac perf bots.

This data stoppage only occurred on Mac (which that changelist affected), but that doesn't mean as much as it might sound like: for some reason, we've apparently *never* successfully identified video rail stages in Windows ref traces, whereas we have on Mac. Regardless, investigating this CL seems worthwhile, and I'm going to ask eyaich@ about it.
 
ref_build_stoppage.png
164 KB View Download
The ref build was actually updated earlier today. Check to see if it's still broken in a few hours?
Will do. I'm somewhat skeptical that it will, just because it doesn't seem to have been broken by a reference build update in the first place, but I would love to be proven wrong!
Cc: -eyaich@chromium.org eya...@chromium.orgm charliea@google.com
Cc: -eya...@chromium.orgm -charliea@google.com eyaich@chromium.org
Cc: rnep...@chromium.org charliea@chromium.org
 Issue 670722  has been merged into this issue.
Bah. aiolos@ updating the ref build on Friday didn't seem to revive these metrics as we were hoping it would.
Interestingly, looking at this graph (https://chromeperf.appspot.com/report?sid=5eac34066514b35865801a6c0a5f81aef8171cce3c1df95074a0d4954e3ea2ad&rev=435383), it looks like the UEs were working again for a brief period over the weekend. What the heck?
Looks like it aligns perfectly with aiolos@'s land of revert of the reference build update over the weekend. Given that, it looks like updating the ref build should fix this, but it remains unclear why this ever broke in the first place.
Status: Fixed (was: Assigned)

Sign in to add a comment