testharnessreport.js: output_document option not supported |
||||||
Issue descriptionUpstream testharness.js supports an output_document option to setup(), in the event that you want to generate test status output in a different document from the one that runs the tests: https://github.com/w3c/testharness.js/blob/master/docs/api.md#setup However, our internal testharnessreport.js does not honor output_document, and just uses 'document' willy-nilly. This is making it hard for me to write/port IntersectionObserver tests that run in an iframe (which is the most important use case).
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70eb799287ce4c2208441fc057053a5b07ceabac commit 70eb799287ce4c2208441fc057053a5b07ceabac Author: szager <szager@chromium.org> Date: Mon Dec 05 20:12:47 2016 testharness.js: support output_document setting. Support output_document as specified here: https://github.com/w3c/testharness.js/blob/master/docs/api.md#setup BUG= 670796 R=foolip@chromium.org,tkent@chromium.org,rbyers@chromium.org Review-Url: https://codereview.chromium.org/2547653005 Cr-Commit-Position: refs/heads/master@{#436382} [modify] https://crrev.com/70eb799287ce4c2208441fc057053a5b07ceabac/third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js [modify] https://crrev.com/70eb799287ce4c2208441fc057053a5b07ceabac/third_party/WebKit/LayoutTests/resources/testharnessreport.js
,
Dec 7 2016
Interesting, do we have an internal version of testharnessreport.js living in imported/wpt that shouldn't be upstreamed to WPT?
,
Dec 7 2016
upstream testharnessreport.js is intentionally left blank; it's just a placeholder for users like us to insert our hooks.
,
Dec 7 2016
Got it, I'll make a bug to exclude that file from any exports.
,
Dec 7 2016
This was fixed in #2 and jeffcarp has filed issue 671890 , so closing this.
,
Jan 3 2017
,
Jan 3 2017
,
Jul 3 2017
,
Jul 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbyers@chromium.org
, Dec 2 2016Labels: Hotlist-PredictabilityInfra
Owner: foolip@chromium.org
Status: Assigned (was: Untriaged)