Playstore Icon missing on ARC++ optin OOBE flow |
|||||||
Issue descriptionChrome Version:56.0.2924.12/9000.12.0 cyan Please specify Cr-* of the system to which this bug/feature applies (add the label below). Launch bug:- https://bugs.chromium.org/p/chromium/issues/detail?id=651144 Steps To Reproduce: (1)Enable --enable-arc-oobe-optin (2) Go through OOBE and login user (3)Check for Google Play icon on top corner Expected Result:Google Play icon on top corner Actual Result:No icon How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3408557009dd278f7272ee07b06704f788509b00 commit 3408557009dd278f7272ee07b06704f788509b00 Author: khmel <khmel@chromium.org> Date: Wed Dec 07 19:57:59 2016 arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. From my investigation, there is the case when Chromebook is loaded first time. OOBE UI initializedd on early step and internet connection is not guaranteed at this moment and this may fail image loading. Fix is to reload image before page is actually shown to user. BUG= 670750 TEST=Manually on device. Restart/Powerwash - in all cases image is loaded. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2560683002 Cr-Commit-Position: refs/heads/master@{#437040} [modify] https://crrev.com/3408557009dd278f7272ee07b06704f788509b00/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Dec 7 2016
,
Dec 8 2016
,
Dec 8 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b12a5eeb28105ccfe41f5070b5f66445dbf24fed commit b12a5eeb28105ccfe41f5070b5f66445dbf24fed Author: khmel <khmel@chromium.org> Date: Thu Dec 08 19:11:05 2016 [Merge-M56] arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. From my investigation, there is the case when Chromebook is loaded first time. OOBE UI initializedd on early step and internet connection is not guaranteed at this moment and this may fail image loading. Fix is to reload image before page is actually shown to user. BUG= 670750 TEST=Manually on device. Restart/Powerwash - in all cases image is loaded. TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2560683002 Cr-Commit-Position: refs/heads/master@{#437040} (cherry picked from commit 3408557009dd278f7272ee07b06704f788509b00) Review-Url: https://codereview.chromium.org/2555743007 Cr-Commit-Position: refs/branch-heads/2924@{#413} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/b12a5eeb28105ccfe41f5070b5f66445dbf24fed/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Dec 8 2016
,
Dec 12 2016
Chrome 56.0.2924.26/900.26.0 cyan |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by khmel@chromium.org
, Dec 7 2016