New issue
Advanced search Search tips

Issue 670747 link

Starred by 1 user
Status: Fixed
Owner:
hongchan@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Increase FIFO size in AudioDestination

Project Member Reported by rtoy@chromium.org, Dec 2 2016 
The fifo size in AudioDestination.cpp (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/audio/AudioDestination.cpp?q=fifoSize&sq=package:chromium&l=44) is currently 8192.

But the UMA stats on Android for the a hardware buffer size of 8064.  (There might be larger values but we can't tell because we return before recording the values if the fifo is too small).

Consider increasing the size of the fifo to something larger and also move at least the recording of the hardware size before we return.

Comment 1 by hongchan@chromium.org, Jan 5 2017

Owner: hongchan@chromium.org
Status: Assigned (was: Available)
The CL refactored the AudioDestination and now it will collect the UMA data before quitting on the invalid buffer size.

https://codereview.chromium.org/2590823007/

We decided to monitor the UMA record for a month and modify the size accordingly.

Comment 2 by hongchan@chromium.org, Jan 13 2017

Labels: OS-All
As of 1/13/2017, the maximum size from UMA is 16384 frames. Depressing, but that means we have to support the buffer size of 2 * 16384 instead of throw away the destination.

One way to preserve the backward compatibility is:
FIFOSize = max(8192, 2 * actualHardwareBufferSize);

Comment 3 by rtoy@chromium.org, Feb 13 2017

Status: Fixed (was: Assigned)
 Issue 678678  has taken care of this.
►

Sign in to add a comment