Issue metadata
Sign in to add a comment
|
Gerrit autolinked "CL:123456" link should go directly to CL |
||||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Go to https://chromium-review.googlesource.com/c/415970/ 2. CQ-DEPEND=CL:415974 What is the expected output? Being shown the CL in question. What do you see instead? Table with "list" of CL consisting of the target CL.
,
Dec 2 2016
,
Dec 2 2016
,
Dec 2 2016
FWIW it works properly in the GWT UI.
,
Dec 2 2016
I don't think this has anything to do with Chromium Gerrit CQ I am the author of. Maybe ChromeOS CQ?
,
Dec 2 2016
,
Dec 2 2016
,
Dec 2 2016
OK, this has somehting to do with PG and ChromeOS. So, keeping Proj-Gerrit-Migration.
,
Dec 2 2016
Ok, I see what's happening here. In GWT Gerrit, if you search for just an integer, and that integer is a valid change number, it redirects you directly to that change. In PolyGerrit, if you do the same, it takes you to a search results page with a single result row. ChromeOS uses a footer called "CQ-DEPEND=CL:123456" as a directive to their CQ. Both versions of Gerrit see the "CL:123456" and try to autolink it. However, they autolink it to be a *search* for that issue number, not a direct link. So, in PolyGerrit, clicking on the autolinked CQ-DEPEND footer takes you to a search results page, instead of directly to the issue. There are two ways to resolve this: * Change the autolink regex which searches for CL:123456 to make it link directly to the issue instead of to a search. That's a configuration change that any git admin can make. * Change PolyGerrit to go directly to the CL when someone searches for just a single change number.
,
Dec 2 2016
andybons/tandrii, PTAL at analysis above and express an opinion on which route forward is better.
,
Dec 3 2016
Analysis -sgtm. Personally, I am dor PG search redirect to issue like GWT. I think it already works that way for changeIDs.
,
Dec 5 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by andyb...@chromium.org
, Dec 2 2016