New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670729 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue gerrit:3789
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:5048


Sign in to add a comment

Gerrit autolinked "CL:123456" link should go directly to CL

Project Member Reported by dtor@chromium.org, Dec 2 2016

Issue description

What steps will reproduce the problem?
1. Go to https://chromium-review.googlesource.com/c/415970/
2. CQ-DEPEND=CL:415974

What is the expected output?
Being shown the CL in question.

What do you see instead?
Table with "list" of CL consisting of the target CL.

 
zKLY7shdjc8.png
44.9 KB View Download
Labels: -Restrict-View-Google
Project: chromium
Moved issue gerrit:5048 to now be  issue chromium:670729 .
Cc: aga...@chromium.org
Components:
Labels: Milestone-Launch Proj-Gerrit-Migration Pri-2
Owner: tandrii@chromium.org
Status: Assigned (was: New)

Comment 4 by dtor@chromium.org, Dec 2 2016

FWIW it works properly in the GWT UI.
I don't think this has anything to do with Chromium Gerrit CQ I am the author of. Maybe ChromeOS CQ?
Cc: -aga...@chromium.org
Components: Infra>Client>ChromeOS
Owner: ----
Status: Untriaged (was: Assigned)
Labels: -Proj-Gerrit-Migration -Milestone-Launch
Labels: Proj-Gerrit-Migration
OK, this has somehting to do with PG and ChromeOS. So, keeping Proj-Gerrit-Migration.
Ok, I see what's happening here.

In GWT Gerrit, if you search for just an integer, and that integer is a valid change number, it redirects you directly to that change. In PolyGerrit, if you do the same, it takes you to a search results page with a single result row.

ChromeOS uses a footer called "CQ-DEPEND=CL:123456" as a directive to their CQ. Both versions of Gerrit see the "CL:123456" and try to autolink it. However, they autolink it to be a *search* for that issue number, not a direct link.

So, in PolyGerrit, clicking on the autolinked CQ-DEPEND footer takes you to a search results page, instead of directly to the issue.

There are two ways to resolve this:
* Change the autolink regex which searches for CL:123456 to make it link directly to the issue instead of to a search. That's a configuration change that any git admin can make.
* Change PolyGerrit to go directly to the CL when someone searches for just a single change number.
Cc: andyb...@chromium.org tandrii@chromium.org
Components: Infra>Codereview>Gerrit
Summary: Gerrit autolinked "CL:123456" link should go directly to CL (was: CQ-DEPEND link should go directly to CL)
andybons/tandrii, PTAL at analysis above and express an opinion on which route forward is better.
Analysis -sgtm. Personally, I am dor PG search redirect to issue like GWT. I think it already works that way for changeIDs.
Mergedinto: gerrit:3789
Status: Duplicate (was: Untriaged)

Sign in to add a comment