New issue
Advanced search Search tips

Issue 670700 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Disabling testScrollPositionRestoring on iOS 9

Project Member Reported by baxley@chromium.org, Dec 2 2016

Issue description

This test is flakily failing on iOS 9, but looks good on iOS10.
 
Labels: M-57 ReleaseBlock-Beta
Marking RBB M-57 to evaluate the impact.
Summary: Disabling testScrollPositionRestoring on iOS 9 (was: Mark testScrollPositionRestoring FLAKY on iOS 9)
Mike, could you please include a failure link
Here is where it is failing:
../../ios/web/shell/test/page_state_egtest.mm:84: error: -[PageStateTestCase testScrollPositionRestoring] : Assertion 'assertWithMatcher:(kindOfClass("UIScrollView") && contentOffset)' failed.

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c654fbbf22e44c70cefdf01e9bdfffaabf837996

commit c654fbbf22e44c70cefdf01e9bdfffaabf837996
Author: baxley <baxley@chromium.org>
Date: Fri Dec 02 17:11:04 2016

Disable testScrollPositionRestoring on iOS 9.

This test is flaky on iOS 9, but works on iOS 10.

BUG= 670700 

Review-Url: https://codereview.chromium.org/2551503002
Cr-Commit-Position: refs/heads/master@{#435960}

[modify] https://crrev.com/c654fbbf22e44c70cefdf01e9bdfffaabf837996/ios/web/shell/test/page_state_egtest.mm

Comment 6 by cma...@chromium.org, Jan 11 2017

Please update this bug including its status if you have started working on it.
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Still disabled on iOS 9 with "TODO( crbug.com/670700 ): Re-enable this test.". Please close if I reopened by mistake.
Thanks for looking out.  I accidentally closed this bug instead of the other bug I was working on on Friday.  Should be finished with this one later today :)
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c91d38d7912b0076bce36e6ad318c197cd6d5a0a

commit c91d38d7912b0076bce36e6ad318c197cd6d5a0a
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Wed Jan 18 19:08:52 2017

Wait for scroll offset in testScrollPositionRestoring.

This ensures that the content offset is applied before attempting
to verify using the contentOffset() matcher.

BUG= 670700 

Review-Url: https://codereview.chromium.org/2637113004
Cr-Commit-Position: refs/heads/master@{#444433}

[modify] https://crrev.com/c91d38d7912b0076bce36e6ad318c197cd6d5a0a/ios/web/shell/test/page_state_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment