`fetch v8` fails on Windows laptop |
||||||
Issue descriptionHere (https://gist.github.com/zeptonaut/66fd47dbf998fefa41a4b1dccab93610) is the full error output. It seems that the underlying problem involves landmines.py failing. I think it's possible this is due to a failure somewhere of replace / (unix systems) with \ (windows systems). My reasoning behind this is the error message at the top of the stack trace: Error: Command 'C:\\Users\\andre_000\\depot_tools\\python276_bin\\python.exe v8/gypfiles/landmines.py' returned non-zero exit status 1 in c:\Users\ANDRE_~1\AppData\Local\Temp\tmpckkbqc Notice that v8/gypfiles/landmines.py uses forward slashes, which could be resulting in the failure. agable@, could you look into this?
,
Dec 2 2016
Punting to iannucci@ for landmines.
,
Dec 5 2016
/ping
,
Dec 5 2016
iannucci@ over IM: "I'll take a look (though I haven't interacted with landmines since I wrote the initial thingy 3 years ago :D) I would probably run fetch with --dry-run and then follow the steps manually to get better output (possibly adding --verbose if the steps fail) "
,
Dec 5 2016
,
Dec 6 2016
The v8 fork of the landmines.py file might have a few minor changes to the original. But I don't see why it wouldn't also fail on our bots. Could you separate the fetching from the hooks to make analyzing this easier? I.e. call separately fetch v8 --nohooks gclient runhooks Please make sure there is only one .gclient file in your cwd afterwards with only the v8 solution in it. The first fetch without the hooks should not fail. If the hooks still fail, please just rerun the cmd line of the failing hook. E.g. the call to landmines.py. Are you trying this checkout in window's temp folder? Could you try the same in a top-level non-spaced folder like c:\playground?
,
Dec 9 2016
After some more investigation, it looks like this was due to the fact that I had a Windows laptop with no (or an out of date?) toolchain. When I reauthenticated with `download_from_google_storage --config` and ran gclient sync, it succeeded after downloading the Windows toolchain. Is there any way that we could check for this and give an easier to understand error message if the person has no toolchain installed?
,
Dec 11 2016
Were there's code there's a way. It doesn't really explain why the landmines failed in the beginning (according to first description). I'll relabel this, as the win toolchain download is not v8 specific, and the problem as you describe it in comment 7 could happen in the chromium workflow as well. But I'm afraid this won't go far without a repro of the problem.
,
Dec 11 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
I took one last look at the error output and couldn't see anything that would direct us towards a solution. No repro steps so closing. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by charliea@chromium.org
, Dec 2 2016