New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670686 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

cronet should set the QUIC user agent ID

Project Member Reported by mef@chromium.org, Dec 2 2016

Issue description

via HttpNetworkSession::Params::quic_user_agent_id

QUIC will soon require that this be non-empty.
 

Comment 2 by mef@chromium.org, Dec 2 2016

Cc: mef@chromium.org rch@chromium.org
Components: Internals>Network>Library
Labels: -OS-Android OS-iOS
Owner: lilyhoughton@chromium.org
Status: Assigned
Cronet on iOS supports QUIC but uses empty value in UrlRequestContextBuilder.
We should fix that similarly to Android counterpart.

Comment 3 by mef@chromium.org, Dec 2 2016

Android CL is here: https://codereview.chromium.org/1665503002/

Comment 4 by mef@chromium.org, Mar 13 2017

Did this land?
Status: Fixed (was: Assigned)

Comment 6 by mef@chromium.org, Dec 14 2017

Status: Started (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8a8ffa1f17fdddd24047c6fee5efe38b99ce21

commit 2d8a8ffa1f17fdddd24047c6fee5efe38b99ce21
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Wed Dec 20 16:00:26 2017

[Cronet] Have Cronet set the QUIC user agent id to a reasonable default on iOS.

Setting the QUIC user agent ID to a non-default value should be done using the experimental options API.

Bug:  670686 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I79bdbde1b1f8be0af3eff7d8d6080974e322b33c
Reviewed-on: https://chromium-review.googlesource.com/822811
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525337}
[modify] https://crrev.com/2d8a8ffa1f17fdddd24047c6fee5efe38b99ce21/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/2d8a8ffa1f17fdddd24047c6fee5efe38b99ce21/components/cronet/ios/cronet_environment.mm

Status: Fixed (was: Started)

Sign in to add a comment