content_shell test ContentViewPopupZoomerTest#testPopupZoomerShowsUp fails on nexus10 in landscape mode
Reported by
mirko.r...@imgtec.com,
Dec 2 2016
|
||||||||
Issue description
Steps to reproduce the problem:
1. put nexus 10 in landscape mode
2./out/Release/bin/run_content_shell_test_apk -f org.chromium.content.browser.ContentViewPopupZoomerTest#testBackKeyDismissesPopupZoomer
What is the expected behavior?
test to pass
What went wrong?
test fail with error:
C 41.132s Main ********************************************************************************
C 41.132s Main [FAIL] org.chromium.content.browser.ContentViewPopupZoomerTest#testPopupZoomerShowsUp:
C 41.132s Main junit.framework.AssertionFailedError: Popup did not get shown.
C 41.132s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
C 41.132s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:89)
C 41.132s Main at org.chromium.content.browser.ContentViewPopupZoomerTest.testPopupZoomerShowsUp(ContentViewPopupZoomerTest.java:102)
C 41.132s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C 41.133s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C 41.133s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 41.133s Main at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:256)
C 41.133s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 41.133s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 41.133s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 41.133s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 41.133s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C 41.133s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C 41.133s Main ********************************************************************************
C 41.133s Main Summary
C 41.133s Main ********************************************************************************
Did this work before? N/A
Chrome version: refs/heads/master@{#435252} Channel: dev
OS Version:
Flash Version:
,
Dec 14 2016
Removing Stability-Sheriff-Android because this is not a crash, but a normal test failure.
,
Dec 15 2016
ajith.v is not active. Assign to tedchoc@ for triage.
,
Jan 25 2017
,
Aug 11 2017
Found this bug report while searching for duplicates prior to submitting my own bug report for failing ContentViewPopupZoomer tests. On some large-screen devices, the two ContentViewPopupZoomerTests now fail due to the generated webpage elements not being close enough to one another to trigger the recently-tuned disambiguation popup. Amazon has a couple devices that exhibit this problem. The overlap requirements for the disambiguation popup were changed here: https://chromium.googlesource.com/chromium/src/+/aca7a78d0cf36f18816de26361a34f0d0b9c7e6c Note: This appears to only be a problem in the test due to the default touch area size from the generated touch event in the test. Manual testing on a copy of the test webpage with a real finger touching the screen causes the disambiguation popup to appear. tedchoc@ - I have a proposed fix for this, but I don't have a Nexus 10 to test my fix on so I can't be 100% sure that this is the same issue. However, I believe it is the same issue and the change should essentially guarantee that the disambiguation popup will appear regardless of screen size. Proposed fix: https://chromium-review.googlesource.com/c/612324/
,
Aug 11 2017
+aelias@ -- The fix seems reasonable to me, but I'm not familiar with that test to say for sure.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ff4b578cb695f2f5aa6eb3ff6bbf6cbd45e8b5 commit e0ff4b578cb695f2f5aa6eb3ff6bbf6cbd45e8b5 Author: Alec Douglas <agdoug@amazon.com> Date: Wed Aug 30 18:44:45 2017 [Android] Ensure popup appears during ContentViewPopupZoomerTests After a recent change to increase the amount of element overlap required for the disambiguation popup to appear, this test would fail on some devices due to the links on the test page not being close enough together. This commit changes the test webpage so all links completely overlap one another to ensure the disambiguation popup appears on all devices. BUG=670676 TEST=all ContentViewPopupZoomerTest.java tests Change-Id: I3350d446331b6c669807c6ad6c873a9b5326ce36 Reviewed-on: https://chromium-review.googlesource.com/612324 Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#498548} [modify] https://crrev.com/e0ff4b578cb695f2f5aa6eb3ff6bbf6cbd45e8b5/AUTHORS [modify] https://crrev.com/e0ff4b578cb695f2f5aa6eb3ff6bbf6cbd45e8b5/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java
,
Aug 30 2017
,
Sep 1 2017
I have tried with Chromium r498858 and test failure reported here (ContentViewPopupZoomerTest#testPopupZoomerShowsUp) is still failing on Nexus10 with Android 5.1.1 in landscape mode.
,
Sep 1 2017
,
Sep 1 2017
Hm that's too bad - like I said, I don't have a Nexus 10 to test with but the change certainly fixed it for the Amazon Fire devices that it was failing on. Are both ContentViewPopupZoomerTests failing or just that one?
,
Sep 5 2017
Yes both tests are failing.
,
Sep 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rsgav...@chromium.org
, Dec 14 2016