Issue metadata
Sign in to add a comment
|
Regression: Hover effect stays on icon beside star icon within omnibox evenafter clicking outside omnibox.
Reported by
dmascare...@etouch.net,
Dec 2 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:56.0.2924.14 (Official Build) 0dc503a1d29c5c8d206cec080ef65b1950451575-refs/branch-heads/2924@{#277} OS: Mac (10.11.6, 10.12.1 ) Pre-condition: Allow 'Location' ,'Midi' and 'Camera' permission for https://permission.site such that its icon is seen within omnibox. What steps will reproduce the problem? 1. Launch chrome and navigate to https://permission.site/ 2. Click on Star icon then click on Folder option drop down of bookmark bubble such that drop down gets open. 3. Click on icons beside star icon (i.e. Location) within omnibox and then click on other icon or outside omnibox. 4. Observe. Actual:Hover effect stays on icons beside star icon (i.e. Location) within omnibox evenafter clicking outside omnibox. Expected: Hover effect should not stay. This is a regression issue, broken in 'M 56' and below is manual bisect info: Good Build: 56.0.2919.0 Bad Build: 56.0.2920.0 Note: Issue is not seen on Windows and Linux OS.
,
Dec 2 2016
Using the per-revision bisect providing the bisect results, You are probably looking for a change made after 431907 (known good), but no later than 431908 (first known bad). CHANGE-LOG URL: --------------------------------------- https://chromium.googlesource.com/chromium/src/+log/97bd029159326fcd0792045a451b99cf9b20c913..2edc6f9145d91684f2151462fa20873c29b87b62 From the CL above, assigning the issue to the concern owner @spqchan : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Dec 2 2016
Adding release block label, please undo if not the case.
,
Dec 2 2016
Also related: click bookmark star (at which point the star is highlighted), then click in the window title bar - the bookmark dialog goes away, but the star remains highlighted.
,
Dec 6 2016
Still able to reproduce the issue on Mac 10.11.6 using latest chrome version 57.0.2943.0. spqchan@ Could you please look into this issue. Thanks!
,
Dec 6 2016
I'm already looking into this
,
Dec 6 2016
Also comment #4, I can't reproduce that. Please file a separate bug
,
Dec 6 2016
This issue was caused by the bubble being opened again when the icon is clicked again. The bubble is supposed to dismiss. Anyway here is the submitted CL in progress: https://codereview.chromium.org/2558443004/
,
Dec 6 2016
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfa3d99e2d870f97146e200f59515a516afda52c commit cfa3d99e2d870f97146e200f59515a516afda52c Author: spqchan <spqchan@chromium.org> Date: Tue Dec 06 20:35:03 2016 [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG= 670621 Review-Url: https://codereview.chromium.org/2558443004 Cr-Commit-Position: refs/heads/master@{#436698} [modify] https://crrev.com/cfa3d99e2d870f97146e200f59515a516afda52c/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h [modify] https://crrev.com/cfa3d99e2d870f97146e200f59515a516afda52c/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
,
Dec 8 2016
Thanks for the fix, we will verify in latest canary. If all looks good please request a merge to M56.
,
Dec 9 2016
With response to comment #11: Above issue is fixed on Latest Chrome Version:57.0.2946.0 (Official Build) 38c3eb61c737a8d3313ca8cd31b0c514c9d35b05-refs/heads/master@{#437422}
,
Dec 9 2016
Tested the same using Mac Pro (10.11.6, 10.12.1 )
,
Dec 9 2016
Awesome, thanks!
,
Dec 9 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49341d417f2e84359018a18f21171084a683b55d commit 49341d417f2e84359018a18f21171084a683b55d Author: spqchan <spqchan@chromium.org> Date: Mon Dec 12 18:15:28 2016 [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG= 670621 Review-Url: https://codereview.chromium.org/2558443004 Cr-Commit-Position: refs/heads/master@{#436698} (cherry picked from commit cfa3d99e2d870f97146e200f59515a516afda52c) Review-Url: https://codereview.chromium.org/2566233002 . Cr-Commit-Position: refs/branch-heads/2924@{#460} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/49341d417f2e84359018a18f21171084a683b55d/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h [modify] https://crrev.com/49341d417f2e84359018a18f21171084a683b55d/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
,
Dec 12 2016
,
Dec 14 2016
Tested in chrome Beta #56.0.2924.28 and Canary #57.0.2951.0 on Mac 10.11.6 by following steps mentioned in the original comment and able to reproduce the issue.Please find the screen cast for reference. @spqchan: Could you please look in to it. Thank you!
,
Dec 14 2016
Assigning to Sarah since the issue is still reproducible.
,
Dec 15 2016
This applies to all icons on the omnibox, other than the bookmark one because the bubble doesn't open when the dialog is open.
,
Dec 17 2016
Apparently in this case, the icon would detect "mouseUp" even when it's not supposed to be focused and will set itself to a hover state. I have a quick and easy fix but it's a bit hacky. I'm going to try come up with a better solution. I'm removing a release blocker because this is a really small edge case.
,
Dec 19 2016
Just to update able to reproduce the issue on Mac 10.12.1 using chrome latest canary version 57.0.2956.0.
,
Jan 2 2017
Just to update able to reproduce the issue on Mac 10.12.2 using chrome latest canary version 57.0.2969.0 spqchan@, Any update on this please.
,
Jan 9 2017
CL in progress: https://codereview.chromium.org/2588543002/
,
Jan 25 2017
,
Feb 7 2017
,
Feb 9 2017
Here is the screenshot of the problem I mentioned in codereview 2588543002.
,
Feb 9 2017
Awesome, thanks! I was able to reproduce this by flipping the flag to enable Material Design in the rest of the browser's native UI
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/450149c5280ffb4ec4e6a5bda73ec42aa49c0fb1 commit 450149c5280ffb4ec4e6a5bda73ec42aa49c0fb1 Author: spqchan <spqchan@chromium.org> Date: Fri Feb 10 22:18:12 2017 [Mac] LocationBarDecoration MouseUp Fix The decoration should ignore mouse up events if a mouse down event didn't happened before it BUG= 670621 Review-Url: https://codereview.chromium.org/2588543002 Cr-Commit-Position: refs/heads/master@{#449758} [modify] https://crrev.com/450149c5280ffb4ec4e6a5bda73ec42aa49c0fb1/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
,
Feb 10 2017
,
Feb 11 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2017
Please merge your change to M57 branch 2987 by 5:00 PM PT Monday (02/13) so we can pick it up for next beta release. Thank you.
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0fe12968923b01fe753e4db64666317d8b32abb commit f0fe12968923b01fe753e4db64666317d8b32abb Author: spqchan <spqchan@chromium.org> Date: Mon Feb 13 20:56:49 2017 [Mac] LocationBarDecoration MouseUp Fix The decoration should ignore mouse up events if a mouse down event didn't happened before it BUG= 670621 Review-Url: https://codereview.chromium.org/2588543002 Cr-Commit-Position: refs/heads/master@{#449758} (cherry picked from commit 450149c5280ffb4ec4e6a5bda73ec42aa49c0fb1) Review-Url: https://codereview.chromium.org/2693803003 . Cr-Commit-Position: refs/branch-heads/2987@{#487} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f0fe12968923b01fe753e4db64666317d8b32abb/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
,
Feb 13 2017
,
Feb 15 2017
Verified this issue on Mac OS 10.12.3 using chrome latest Beta M57-57.0.2987.54 by following steps mentioned in the original comment, Observed the hover effect is keep moving on clicking various icons in the omnibox as expected. Hence adding TE-Verified label. Thanks!
,
Mar 4 2017
,
Mar 15 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 2 2016