New issue
Advanced search Search tips

Issue 670619 link

Starred by 4 users
Status: Untriaged
Owner: ----
Cc:
haraken@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove DummyExceptionStateForTesting from production code

Project Member Reported by haraken@chromium.org, Dec 2 2016 
Currently DummyExceptionStateForTesting is used in a couple of places in production code to ignore thrown exceptions.

In general, it's wrong to ignore exceptions in production code. If we really need to ignore the exception for some special reason, we should explicitly call exceptionState.clearException() instead of relying on DummyExceptionStateForTesting.

Comment 1 by ajha@chromium.org, Dec 3 2016

Labels: M-57
Tagging with current canary milestone.

Comment 2 by slangley@chromium.org, Dec 15 2016

Owner: slangley@chromium.org
Status: Assigned (was: Available)
I'll take a look at this
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44f9d281fad4e41cbb47dd63327754d41fd20190

commit 44f9d281fad4e41cbb47dd63327754d41fd20190
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 16:04:20 2017

Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING

ExceptionState should not be ignored in production code unless you have
a strong reason to do so. However, people have abused IGNORE_EXCEPTION
and ignored ExceptionState that should not be ignored...

To discourage further mis-usage, this CL renames IGNORE_EXCEPTION to
IGNORE_EXCEPTION_FOR_TESTING.

BUG=670619

Review-Url: https://codereview.chromium.org/2615953003
Cr-Commit-Position: refs/heads/master@{#441945}

[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/EphemeralRangeTest.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/TimeRanges.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/TimeRangesTest.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/inspector/DOMEditor.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/inspector/InspectorHistory.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/loader/HttpEquiv.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/web/WebElement.cpp
[modify] https://crrev.com/44f9d281fad4e41cbb47dd63327754d41fd20190/third_party/WebKit/Source/web/WebNode.cpp

Comment 4 by slangley@chromium.org, Jan 24 2018

Owner: ----

Comment 5 by benhenry@google.com, Jan 11

Status: Untriaged (was: Assigned)
Assigned, but no owner or component? Please find a component and/or owner
►

Sign in to add a comment