New issue
Advanced search Search tips

Issue 670616 link

Starred by 2 users
Status: Fixed
Owner:
peria@chromium.org
Closed: Aug 2017
Cc:
yukishiino@chromium.org
haraken@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

V8HiddenValue should be replaced with V8PrivateProperty

Project Member Reported by haraken@chromium.org, Dec 2 2016 
V8PrivateProperty is faster than V8HiddenValue. We should replace V8HiddenValue with V8PrivateProperty. Then deprecate V8HiddenValue.

Comment 1 by jbroman@chromium.org, Jan 4 2017 

Is there still a large performance difference, now that V8HiddenValue is also backed by Object::SetPrivate (although it doesn't expose the fast-path of retaining the symbol that V8PrivateProperty permits).

Regardless, deduplicating is probably a win from a code simplifity POV.

Comment 2 by haraken@chromium.org, Jan 4 2017

Cc: yukishiino@chromium.org
> although it doesn't expose the fast-path of retaining the symbol that V8PrivateProperty permits

IIUC, this is the bottleneck of V8HiddenValue.

> Regardless, deduplicating is probably a win from a code simplifity POV.

Yes.

Comment 3 by peria@chromium.org, Aug 9 2017

Owner: peria@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment