Issue metadata
Sign in to add a comment
|
Regression : On right click, unnecessarily grey focus stays on Avatar icon.
Reported by
yfulgaon...@etouch.net,
Dec 2 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2924.14 (Official Build) 0dc503a1d29c5c8d206cec080ef65b1950451575-refs/branch-heads/2924@{#277} 64 bit OS : Mac(10.11.6, 10.12.1, 10.12) Precondition : Please make sure that Chrome has only one user. What steps will reproduce the problem? 1. Launch chrome and right click on ‘Avatar’ icon. 2. Now click (left click) on wrench menu and observe the grey focus on Avatar icon. Actual : On right click, grey focus stays on Avatar icon and focus does not vanish even after clicking anywhere on the page. Expected : Instead, on right click grey focus should not stay on Avatar icon when there is only one user in chrome. This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info. Good build : 56.0.2908.0 Bad build : 56.0.2909.0 Note : This is Mac specific issue and the same is not reproducible on Windows & Linux OS.
,
Dec 2 2016
Adding release block label, please undo if not the case.
,
Dec 7 2016
,
Dec 8 2016
Thanks for the fix, once its committed we will verify in latest canary. If all looks good please request a merge to M56.
,
Dec 9 2016
With response to comment #4: Still able to reproduce the issue on Mac(10.11.6, 10.12.1, 10.12) OS using latest canary 57.0.2946.0, please review an attached screen cast. Thank you!
,
Dec 9 2016
Whoops, should've commented earlier. The CL hasn't landed yet
,
Dec 12 2016
Just to update Still able to reproduce this issue on Mac 10.12.1 using latest canary #57.0.2949.0. Thanks...!!
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c0be82a912cb5ef954980c924c32b99740f761c commit 8c0be82a912cb5ef954980c924c32b99740f761c Author: spqchan <spqchan@chromium.org> Date: Mon Dec 12 23:15:19 2016 [Mac] Fix for avatar button active state and removed fast chooser profile code - The avatar button should only be set as active if the a bubble is opened - Removed the code for the fast chooser in the cocoa files BUG= 670613 Review-Url: https://codereview.chromium.org/2552423002 Cr-Commit-Position: refs/heads/master@{#437947} [modify] https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h [modify] https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm [modify] https://crrev.com/8c0be82a912cb5ef954980c924c32b99740f761c/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
,
Dec 13 2016
,
Dec 13 2016
Tested the same on mac 10.11.6 chrome version 57.0.2950.0 - avatar button is active only if the bubble is opened. Clicking elsewhere removes the focus as well as the bubble on avatar button. Please find the screencast Fix works as expected
,
Dec 13 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 13 2016
Your change has been approved for M56. Please merge your CL ASAP so that we could take it for next Beta and RC at 3.00 PM today- Dec 13.
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/362edf00e6b76e166cf3096ba4675d376330a418 commit 362edf00e6b76e166cf3096ba4675d376330a418 Author: spqchan <spqchan@chromium.org> Date: Tue Dec 13 23:33:04 2016 [Mac] Fix for avatar button active state and removed fast chooser profile code - The avatar button should only be set as active if the a bubble is opened - Removed the code for the fast chooser in the cocoa files BUG= 670613 Review-Url: https://codereview.chromium.org/2552423002 Cr-Commit-Position: refs/heads/master@{#437947} (cherry picked from commit 8c0be82a912cb5ef954980c924c32b99740f761c) Review-Url: https://codereview.chromium.org/2569403002 . Cr-Commit-Position: refs/branch-heads/2924@{#479} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/362edf00e6b76e166cf3096ba4675d376330a418/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h [modify] https://crrev.com/362edf00e6b76e166cf3096ba4675d376330a418/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/362edf00e6b76e166cf3096ba4675d376330a418/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm [modify] https://crrev.com/362edf00e6b76e166cf3096ba4675d376330a418/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
,
Dec 14 2016
Tested the same on mac 10.11.6 chrome version 56.0.2924.28 - avatar button is active only if the bubble is opened. Clicking elsewhere removes the focus as well as the bubble on avatar button. Please find the screencast Fix works as expected
,
Dec 20 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 2 2016Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)