Split V8's gatekeeper_ng into a tree-closing and a non-tree-closing one |
||||
Issue descriptionIt is not possible with gatekeeper_ng to mix notifications that close and others that don't close the tree for a builder on the same tree. Originally there was a sections-feature in gatekeeper to deal with this, but it was removed. This proposes to overcome this problem by running independent gatekeeper instances with independent configs. In particular we'll split off V8's gatekeeper from the others. We'll then split V8's gatekeeper config into several: - One for all tree closers - One for each type of breakage that should cause an email only to the blamelist when the breakage occurs for the first time. A possible negative impact might be a higher request load on the v8 masters as: - before, there was a natural but undesired delay when v8 gatekeeper waited for all others like chromium.fyi to be processed, - several gatekeeper instances for the same master poll more frequently as they scale up To mitigate possible overloading, we could make the polling frequency a bit lower for those instances.
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef commit 6c2a0017a5f8279ae7c6f64204b1fc92b10822ef Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Dec 02 13:07:50 2016 Split off V8 from gatekeeper.json Also adds a test case using production data for the trees file for better coverage. BUG= 670608 Change-Id: I5328dec1a7cb168ae0245991378a9a9c8a21b2e0 Reviewed-on: https://chromium-review.googlesource.com/415733 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/gatekeeper.json [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/gatekeeper_ng_config.py [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/gatekeeper_trees.json [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/recipe_modules/gatekeeper/api.py [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/recipe_modules/gatekeeper/test_api.py [add] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/recipes/gatekeeper.expected/production_data.json [modify] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/recipes/gatekeeper.py [add] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/v8/OWNERS [add] https://crrev.com/6c2a0017a5f8279ae7c6f64204b1fc92b10822ef/scripts/slave/v8/gatekeeper_v8_tree_closers.json
,
Dec 2 2016
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b2c7a9ec49708989d20294af690026f9475280ff commit b2c7a9ec49708989d20294af690026f9475280ff Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Dec 02 14:25:35 2016 V8: Add gatekeeper step for node.js notifications. BUG= v8:5680 , chromium:670608 Change-Id: I5a44330018a0fdbd26553ac671bf4163e90c0fba Reviewed-on: https://chromium-review.googlesource.com/415950 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/b2c7a9ec49708989d20294af690026f9475280ff/scripts/slave/gatekeeper_trees.json [modify] https://crrev.com/b2c7a9ec49708989d20294af690026f9475280ff/scripts/slave/recipes/gatekeeper.expected/production_data.json [add] https://crrev.com/b2c7a9ec49708989d20294af690026f9475280ff/scripts/slave/v8/gatekeeper_v8_node.json
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/cb659d1c0cb4272a726d2da93a0075e381f4b896 commit cb659d1c0cb4272a726d2da93a0075e381f4b896 Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Dec 05 08:45:32 2016 Gatekeeper code cleanup. Cleaning up follow-up comments from: https://chromium-review.googlesource.com/#/c/415733/ BUG= 670608 TBR=stip@chromium.org,tandrii@chromium.org Change-Id: I55652f318170e0461dffea5289598dd9ecfa1b71 Reviewed-on: https://chromium-review.googlesource.com/416779 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/cb659d1c0cb4272a726d2da93a0075e381f4b896/scripts/slave/recipe_modules/gatekeeper/api.py [modify] https://crrev.com/cb659d1c0cb4272a726d2da93a0075e381f4b896/scripts/slave/recipe_modules/gatekeeper/test_api.py
,
Jan 18 2017
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
,
Feb 10 2017
,
Dec 11 2017
Long done. |
||||
►
Sign in to add a comment |
||||
Comment 1 by machenb...@chromium.org
, Dec 2 2016