New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670607 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression

Blocking:
issue 696627
issue 707839



Sign in to add a comment

[Nexus 7] Transient visual garbage when switching tabs

Reported by kye...@ratchetqa.com, Dec 2 2016

Issue description

Application Version: Chrome 57.0.2939.0
Android Build Number: 6.0.1/MOB30X
Device: Nexus 7

Steps to reproduce: 
1. Launch Chrome.
2. Go to any site or google search anything(ex.hi).
3. Open NTP.
4. Switch between two tabs 4-5 times> Observe.

Observed behavior: 
Tab is getting cropped from the top while randomly switching between tabs.

Expected behavior: 
Tab should not get cropped.

Frequency: 
<5/5>

Additional comments: 
1.Good build: 57.0.2929.0
  Bad build : 57.0.2931.0
2.This issue is not present on latest M-56.0.2924.13 build.
3.This issue is reproducible on Nexus 7(6.0.1/MOB30X)

Bisect Range : https://chromium.googlesource.com/chromium/src/+log/57.0.2929.0..57.0.2931.0?pretty=fuller&n=10000
 
Please find logs and Video @ http://go/chrome-androidlogs1/6/670607
Components: UI>Browser>Mobile>TabSwitcher
Labels: -Pri-3 hasbisect-per-revision ReleaseBlock-Beta M-57 Pri-2 Type-Bug-Regression
Owner: trchen@chromium.org
Status: Assigned (was: Unconfirmed)
trchen@, Can you please look in to this, Thanks!
Issue 670639 has been merged into this issue.
kyeole / kgnaidu - Does this still repro?
This issue is still reproducible on latest M-57.0.2987.8 with below mentioned steps,

1. Launch Chrome.
2. Go to any site or google search anything in two tabs.
3. Switch between two tabs 4-5 times> Observe tab corruption appears while switching between tabs.
URGENT - PLEASE REVIEW ASAP

Greetings from the release team!

This bug is marked as an M-57 beta blocker, which means it needs to be fixed on trunk by THIS FRIDAY, Jan 27 in order to be merged back to the M57 branch on time.  Please prioritize fixing this issue.

Unsure if this bug should block the beta release, or know it should block but you won't be able to fix it in time?  CC me to this bug and we can discuss.

If you're absolutely sure this should not block beta, the bug can be punted to stable (by changing ReleaseBlock-Beta to ReleaseBlock-Stable), or if the bug should not block the release at all simply remove the release block tag.

Thanks,
Alex

Comment 8 by trchen@chromium.org, Jan 25 2017

Cc: aelias@chromium.org briander...@chromium.org
Components: -UI>Browser>Mobile>TabSwitcher Internals>Compositing Internals>GPU
Status: Started (was: Assigned)
It looks very similar to the Qualcomm FBO/scissor bug we had a few years ago.

I tried a few workarounds yesterday and confirmed if we skip resetting scissor rect in GLRenderer::BeginDrawingFrame, the problem goes away. I haven't figured out how the bug works exactly. It could be another manifestation of the driver bug, or it could be a bug in our command buffer workarounds. Investigation continues.

Comment 9 by aelias@chromium.org, Jan 25 2017

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Summary: [Nexus 7] Transient visual garbage when switching tabs (was: [Nexus 7] Tab is getting cropped from the top while randomly switching between tabs)
Downgrading to stable blocker because it only affects one single device.  (I know from past experience that Nexus 7 2013 has flicker bugs that affect no other Qualcomm device, so I don't think it should be more widespread.)
Investigation done. Fix pending: https://codereview.chromium.org/2655073008/
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1870af92713b4c2eefd45312b7cf9c5c18477f59

commit 1870af92713b4c2eefd45312b7cf9c5c18477f59
Author: trchen <trchen@chromium.org>
Date: Sat Jan 28 03:12:23 2017

[gpu/GLES2DecoderImpl] Force updating scissor state on Nexus 7 gen.2

Nexus 7 gen.2 shipped with some buggy GPU driver that can have stale
scissor state after switching current framebuffer to FBO0.

The theory is that FBO0 keeps some internal (in HW regs maybe?) scissor test
state, but the driver forgets to update it with GL_SCISSOR_TEST when FBO0 gets
bound. (So it stuck with whatever state we last switched from it.)

Also the state could stuck even if we explicitly set GL_SCISSOR_TEST again
after switching to FBO0, because the driver early exits if the new
GL_SCISSOR_TEST value matches the old one.

This CL add a workaround in GLES2DecoderImpl to shake up the scissor state
whenever we just switched to FBO0.

BUG= 670607 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2655073008
Cr-Commit-Position: refs/heads/master@{#446894}

[modify] https://crrev.com/1870af92713b4c2eefd45312b7cf9c5c18477f59/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/1870af92713b4c2eefd45312b7cf9c5c18477f59/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/1870af92713b4c2eefd45312b7cf9c5c18477f59/gpu/config/gpu_driver_bug_workaround_type.h

Labels: Merge-Request-57
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Feb 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Merged
Status: Fixed (was: Started)
Hmm somehow bugdroid missed the commit. It's in.

Cr-Commit-Position: refs/branch-heads/2987@{#203}
Labels: -Restrict-View-Google -Merge-Merged -Hotlist-Merge-Approved -Merge-Approved-57 merge-merged-2987

Comment 17 by kye...@etouch.net, Feb 14 2017

This issue is fixed on latest M-57.0.2987.52 & M-58.0.3012.0
Status: Verified (was: Fixed)

Comment 19 by kbr@chromium.org, Mar 1 2017

Blocking: 696627
Blocking: 707839

Sign in to add a comment