Do not switch from arc-loading to lso-loading page. |
||||||
Issue descriptionChrome Version: ToT OS: ChromeOS How to repro: - Enable ARC and accept ToS on Opt-in flow. Expected behavior: - Showing "this may take up to a minute or so..." - then switch to "SIGN IN" page. Actual behavior: - Showing "This may take up to a minute or so..." - Followed by "Just a sec..." - then switch to "SIGN IN" page. According to the discussion with Hiro, it is not user beneficial and we should remove it. Note that, we still keep showing the "Just a sec..." loading page, in some edge cases intentionally. E.g.; 1) User accepts ToS, then logs-out from ChromeOS. Then re-login. 2) Clicking "SIGN IN" fails for some reason. Then clicking retry. Note: this is side-effect of the opt-in auth/re-auth flow merging done at M-56. Needs to be cherry-picked.
,
Dec 5 2016
,
Dec 5 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e01c41ab191fd19a374804af87ab24eac6b8a49 commit 6e01c41ab191fd19a374804af87ab24eac6b8a49 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Tue Dec 06 05:13:11 2016 Do not show "Just a sec" page if arc-loading page is shown. The "Just a sec" page looks redundant if we already show "This may take up to a minute or so..." loading page, from users' perspective. Then, skip to show it. BUG= 670606 BUG=b/33163416 TEST=Ran bots. TEST=Manually run opt-in flow. Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page. TEST=Manually run opt-in flow. Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account. Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page. TEST=Manually run opt-in flow. Accept ToS. While "SIGN IN" is shown, disable network. Click "SIGN IN" and show error page. Re-establish the network. Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before "SIGN IN" page is re-shown. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2545793003 Cr-Commit-Position: refs/heads/master@{#436155} (cherry picked from commit a1972e35f5d748015b9d9df96cfb3098c450bf36) Review URL: https://codereview.chromium.org/2552183002 . Cr-Commit-Position: refs/branch-heads/2924@{#353} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/6e01c41ab191fd19a374804af87ab24eac6b8a49/chrome/browser/resources/chromeos/arc_support/background.js
,
Dec 16 2016
,
Feb 10 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 3 2016