New issue
Advanced search Search tips

Issue 670599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 649700



Sign in to add a comment

Strike line (<s> and <del>, text-decoration-line: line-through) should not get affected by text-decoration-skip: ink

Project Member Reported by ebra...@gnu.org, Dec 2 2016

Issue description

Chrome Version: 57
OS: macOS 11.12

What steps will reproduce the problem?
data:text/html;charset=utf8,<s style="font-size: 50px; text-decoration-skip: ink"><script>document.write(Array(30).join("ijk ijk ijk "))</script></s>

What is the expected result?
Strike across the text without skipping.

What happens instead?
It is skipping text regions which doesn't seem right.

Perhaps this should be considered with "text-decoration-skip: auto" or always? I think best result is what Safari currently does with "text-decoration-line: line-through underline" on the following case:

data:text/html;charset=utf8,<span style="font-size: 50px; text-decoration-skip: ink; -webkit-text-decoration-line: line-through underline; text-decoration-line: line-through underline;"><script>document.write(Array(30).join("ijk ijk ijk "))</script></span>
 

Comment 1 by drott@chromium.org, Dec 2 2016

Please see: https://github.com/w3c/csswg-drafts/issues/711 and feel to contribute to that discussion.

"... which doesn't seem right" should be resolved in the spec.

Comment 2 by drott@chromium.org, Dec 2 2016

Owner: drott@chromium.org
Status: Available (was: Untriaged)
Components: Blink>Paint

Comment 5 by drott@chromium.org, Dec 22 2016

Blocking: 649700
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a91abd16665860a7ab53a307b8e87c5783fbc6c

commit 9a91abd16665860a7ab53a307b8e87c5783fbc6c
Author: drott <drott@chromium.org>
Date: Wed Jan 18 13:16:53 2017

Do not apply ink-skipping to line-through text decoration

Discussion resolved in WG issue tracker:
https://github.com/w3c/csswg-drafts/issues/711

BUG= 670599 
R=kojii
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2600453003
Cr-Commit-Position: refs/heads/master@{#444343}

[modify] https://crrev.com/9a91abd16665860a7ab53a307b8e87c5783fbc6c/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png
[modify] https://crrev.com/9a91abd16665860a7ab53a307b8e87c5783fbc6c/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Comment 9 by drott@chromium.org, Jan 18 2017

Status: Fixed (was: Available)

Sign in to add a comment