New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670587 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

"TVInputComposite" and "TVInputComponent" of KeyboardEvent.key are miss mapped on Android

Reported by dtoybo...@gmail.com, Dec 2 2016

Issue description

Steps to reproduce the problem:
https://cs.chromium.org/chromium/src/ui/events/keycodes/keyboard_code_conversion_android.cc?sq=package:chromium&dr=C&l=336

AKEYCODE_TV_INPUT_COMPOSITE* are mapped to "TVInputComponent*".
AKEYCODE_TV_INPUT_COMPONENT* are mapped to "TVInputComposite*".

I.e., swapped between Composite and Component.

What is the expected behavior?

What went wrong?
Sorry, this wrong mapping from my report at  issue #662011 .

Did this work before? No 

Does this work in other browsers? Yes

Chrome version:   Channel: dev
OS Version: 
Flash Version:
 
Owner: chongz@chromium.org
Status: Assigned (was: Unconfirmed)
Labels: Hotlist-Input-Dev
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bacc700b3d89b58024d726567a4947f05fa24af5

commit bacc700b3d89b58024d726567a4947f05fa24af5
Author: chongz <chongz@chromium.org>
Date: Wed Jan 11 16:54:24 2017

[Android DomKey] Swap mapping for TVInputComposite and TVInputComponent

https://crrev.com/2501083002/ introduce these mappings but mis-placed values,
this CL swaps these values back.

BUG= 670587 

Review-Url: https://codereview.chromium.org/2622893005
Cr-Commit-Position: refs/heads/master@{#442929}

[modify] https://crrev.com/bacc700b3d89b58024d726567a4947f05fa24af5/ui/events/keycodes/keyboard_code_conversion_android.cc

Comment 4 by chongz@chromium.org, Jan 11 2017

Labels: M-57
Status: Fixed (was: Assigned)

Sign in to add a comment