New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670585 link

Starred by 2 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jan 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ ranjitkan@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted space is seen in wrench menu after checking 'Always show icon' option of 'cast'.

Reported by rk...@etouch.net, Dec 2 2016 
Chrome Version : 56.0.2924.14 (Official Build) 0dc503a1d29c5c8d206cec080ef65b1950451575-refs/branch-heads/2924@{#277} 32/64 bit
OS : Mac(10.11.6, 10.12.1, 10.12)

What steps will reproduce the problem?
(1) Launch chrome, right click on NTP and select 'Cast' option (cast overlay opens and cast icon is seen near wrench menu).
(2) Drag the cast icon to wrench menu then right click on option and check Always show icon option. 
(3) Close the cast overlay and click on wrench menu, observe.

Actual: Unwanted space is seen in wrench menu after checking Always show icon option of cast.

Expected: No such unwanted space should seen.

This is regression issue, broken in 'M 56' and will soon update the other info:

Good build:56.0.2915.0
Bad build:56.0.2916.0

Note: Issue is not seen on Windows and Linux OS.
Actual_Wrenchmenu.mov
6.0 MB Download

Comment 1 by kkaluri@chromium.org, Dec 2 2016

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: taku...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 56.0.2915.0,  Revision Range 	431137
Bad build  : 56.0.2916.0,  Revision Range 	431463

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/116138bad2403c5f51580005842f226beab0bf2e..89fc2a78d69cb432b445da453fd3f6fd02d4ebfe

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/89fc2a78d69cb432b445da453fd3f6fd02d4ebfe

From the above CL suspecting the below change
---------------------------
https://codereview.chromium.org/2410553002

takumif@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by ranjitkan@chromium.org, Dec 2 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by taku...@chromium.org, Dec 2 2016

Labels: -Pri-1 -M-56 -ReleaseBlock-Stable M-57 Pri-2

Comment 4 by taku...@chromium.org, Dec 15 2016

Components: Internals>Cast>UI
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d325bc6eacf649f14b1fddce78e1268c8b6e89

commit 05d325bc6eacf649f14b1fddce78e1268c8b6e89
Author: takumif <takumif@chromium.org>
Date: Tue Jan 03 23:35:36 2017

[Media Router Action] Hide action back in the overflow menu after popping it out

In macOS, when the user right clicks on the media router action while it's in
the toolbar overflow menu, it gets popped out onto the toolbar to show its
context menu. This change makes the action go back into the overflow menu once
the context menu is closed, which will be consistent with the behavior of
extension actions.

BUG= 670585 

Review-Url: https://codereview.chromium.org/2579613002
Cr-Commit-Position: refs/heads/master@{#441253}

[modify] https://crrev.com/05d325bc6eacf649f14b1fddce78e1268c8b6e89/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
[modify] https://crrev.com/05d325bc6eacf649f14b1fddce78e1268c8b6e89/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/05d325bc6eacf649f14b1fddce78e1268c8b6e89/chrome/browser/ui/toolbar/media_router_action.h

Comment 6 by taku...@chromium.org, Jan 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment