New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670581 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Weird behaviour of filter text box is seen in Network section of devtools.

Reported by yfulgaon...@etouch.net, Dec 2 2016

Issue description

Chrome Version : 56.0.2924.14 (Official Build) 0dc503a1d29c5c8d206cec080ef65b1950451575-refs/branch-heads/2924@{#277} 32/64 bit
OS : Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and open devtools on any page.
2. Navigate to ’Network’ tab and type letter ‘d’ or ‘m’ in filter text box, observe below the ‘Regex’ and ‘Hide data URLs’ check boxes. 
3. Now hit Backspace key and observe.

Actual Results : 1. Unwanted faint underline is seen below ‘Regex’ and ‘Hide data URLs’ check boxes.
	         2. Suggestions list is not displayed after entering alphabets like ‘d’, ‘m’.
	         3. Unable to delete text from ‘Filter’ text box using Backspace key.

Expected Results: 1. No faint underline should be seen and suggestions list should appear for user inputs.
                  2. User should be able to delete the text from ‘Filter’ text box using Backspace key. 

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info.
Good build : 56.0.2903.0
Bad build : 56.0.2906.0
 
Act_Exp_devtools.png
128 KB View Download
Actual_devtools.mov
8.3 MB Download
Expected_devtools.mov
8.2 MB Download
Labels: hasbisect-per-revision
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2903.0 (Revision: 428431).
Bad build: 56.0.2906.0 (Revision: 428890).

You are probably looking for a change made after 428515 (known good), but no later than 428516 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d509d739efec6c000cea40aae5e24f8b432cf3d5..beee5025a4557f5ea443e7583aa508a26d85ad3d

@einbinder -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Labels: ReleaseBlock-Beta
Adding Release block label, please undo if not the case.
M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.

einbinder@ please take a look ASAP
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Please have a fix  before M56 hits stable.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60923e44a7116db275bf8c74b1cd52ba2335b1af

commit 60923e44a7116db275bf8c74b1cd52ba2335b1af
Author: einbinder <einbinder@chromium.org>
Date: Wed Dec 07 00:27:42 2016

DevTools: Fix SuggestBox not showing without a maximum height

BUG= 670581 

Review-Url: https://codereview.chromium.org/2554173002
Cr-Commit-Position: refs/heads/master@{#436775}

[modify] https://crrev.com/60923e44a7116db275bf8c74b1cd52ba2335b1af/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Thanks for the fix, we will verify in latest canary. If all looks good please request a merge to M56.
Labels: TE-Verified-M57 TE-Verified-57.0.2946.0
With response to comment #7:

Above issue is fixed on Latest Mac canary 57.0.2946.0 (Official Build) 38c3eb61c737a8d3313ca8cd31b0c514c9d35b05-refs/heads/master@{#437422}
Just to update,
Above issue is also fixed on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS in latest canary 57.0.2946.0 build.
If there is no pending work, please request a merge to M56.
Issue is still seen on latest beta 56.0.2924.28	.

einbinder@, Could you please merge the fix to M56 if there is no pending work.
Please request a merge to M56 since its fixed in canary.

FYI: Your bug is labelled as Stable Release Block, please make sure to land the fix and get it merged into the release branch ASAP so we can take it for next week's Beta release for Desktop. Thank you!
Issue is still seen on latest beta 56.0.2924.51.

einbinder@ - Could you please merge the fix to M56 as this issue has been marked as release block stable.

Thanks...!!
Just to update, issue is still seen on mac 10.12.2 using latest beta #56.0.2924.59.

einbinder@ - Friendly ping...!!

Could you please merge the fix to M56 as this issue has been marked as release block stable.

Thanks...!!
einbinder@, Gentle Ping!

Could you please merge the fix to M56
Labels: Needs-triage-Mobile
Labels: -Needs-triage-Mobile
Labels: Merge-Request-56
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 1 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Approved-56
Approving on behalf of Richard.
Labels: -Merge-Approved-56 merge-merged-2924
Already merged.

https://chromium.googlesource.com/chromium/src.git/+/f854fb0bd110ef02f0a8408aae412917ab54adcd
Cc: ligim...@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.2 using chrome version 56.0.2924.87.

1. Unwanted faint underline is seen below ‘Regex’ and ‘Hide data URLs’ check boxes.
2. Suggestions list is not displayed after entering alphabets like ‘d’, ‘m’.

But 3.still Unable to delete text from ‘Filter’ text box using Backspace key.

Please find the attached screen shot for the same.
einbinder@ Please confirm on this behavior.

Thanks,
670581.png
86.1 KB View Download
Labels: -Merge-Review-56
Labels: -M-56 M-57
The fix did not work for M56, please resolve for M57.
A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Started)
I am seeing this fixed in 57.

Sign in to add a comment