New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670580 link

Starred by 0 users
Status: Fixed
Owner:
█ kochi@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 633007



Sign in to add a comment

Shadow Piercing Descendant Combinator is not enabled under experimental flag

Project Member Reported by kochi@chromium.org, Dec 2 2016 
At  issue 633007 , '>>>' was implemented, but its RuntimeEnabledFeatures
flag is still 'test', not experimental.

That means developers still cannot use with the experimental web
platform features flag, although you can still use
--enable-blink-features=ShadowPiercingDescendantCombinator as a last
resort.

Flipping the flag to 'experimental', and merge to M56 is needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77433598cc3160b0b324e53e8ab1db8ff1fea2d3

commit 77433598cc3160b0b324e53e8ab1db8ff1fea2d3
Author: kochi <kochi@chromium.org>
Date: Fri Dec 02 08:43:13 2016

Change ShadowPiercingDescendantCombinator flag to experimental

It used to be test only, but should have been experimental to be
used under the "experimental web platform features" flag.

BUG= 670580 

Review-Url: https://codereview.chromium.org/2545003002
Cr-Commit-Position: refs/heads/master@{#435887}

[modify] https://crrev.com/77433598cc3160b0b324e53e8ab1db8ff1fea2d3/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 2 by kochi@chromium.org, Dec 2 2016

Status: Fixed (was: Started)

Comment 3 by kochi@chromium.org, Dec 2 2016

Labels: M-56 Merge-Request-56
This flag change (test -> experimental) needs merging to M56, otherwise
what were merged to M56 in  issue 633007  are almost meanless.

Requesting merge to M56.

Comment 4 by dimu@chromium.org, Dec 3 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/958f312c3ace7b732af886c2e36e255092b30599

commit 958f312c3ace7b732af886c2e36e255092b30599
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Mon Dec 05 01:58:35 2016

Change ShadowPiercingDescendantCombinator flag to experimental

It used to be test only, but should have been experimental to be
used under the "experimental web platform features" flag.

BUG= 670580 

Review-Url: https://codereview.chromium.org/2545003002
Cr-Commit-Position: refs/heads/master@{#435887}
(cherry picked from commit 77433598cc3160b0b324e53e8ab1db8ff1fea2d3)

Review URL: https://codereview.chromium.org/2548233002 .

Cr-Commit-Position: refs/branch-heads/2924@{#324}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/958f312c3ace7b732af886c2e36e255092b30599/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
►

Sign in to add a comment