SVG <use> elements should use a closed shadow tree, instead of a user agent shadow tree |
||||
Issue descriptionAccording to the latest SVG spec (https://svgwg.org/svg2-draft/struct.html#UseShadowTree), SVGUseElement should use open shadow trees, instead of UA shadow trees. > The shadow tree is open (inspectable by script), but read-only. Any attempt to directly modify the elements, attributes, and other nodes in the shadow tree must throw a NoModificationAllowedError. The spec also says that it should be read-only, though I am not sure whether it is feasible or not in a reasonable way.
,
Mar 15 2017
,
Mar 15 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17fa68c396c45e6650df5dd2777a0112800ae61d commit 17fa68c396c45e6650df5dd2777a0112800ae61d Author: hayato <hayato@chromium.org> Date: Thu Mar 16 10:11:21 2017 Change the type of a SVG <use> element's shadow tree from "user agent" to "closed" The SVG 2's spec is: https://svgwg.org/svg2-draft/struct.html#UseElement Because SVG spec has been updated to clarify that SVG's <use> element should use a shadow tree as its implementation, we must use the *standard* shadow tree which DOM Standard defines its behavior. That is either an open shadow root or a closed shadow root. It should not be a user-agent shadow root because it is UA's internal concept. Though the SVG spec says nothing about which type of Shadow Root should be used, this CL chose "closed" because it is more compatible to the behavior of user-agent shadow root. Eventually, the spec should clarify the type. BUG= 670572 Review-Url: https://codereview.chromium.org/2752763002 Cr-Commit-Position: refs/heads/master@{#457391} [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/input/GestureManager.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/layout/HitTestResult.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/layout/HitTestResult.h [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/svg/SVGElement.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/svg/SVGUseElement.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/core/svg/SVGUseElement.h [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/web/PageWidgetDelegate.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/17fa68c396c45e6650df5dd2777a0112800ae61d/third_party/WebKit/Source/web/WebViewImpl.cpp
,
Mar 16 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hayato@chromium.org
, Dec 2 2016