New issue
Advanced search Search tips

Issue 670562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 659917



Sign in to add a comment

blob related tests in virtual/mojo-loading/http/tests/xmlhttprequest/ are flaky

Project Member Reported by yhirano@chromium.org, Dec 2 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/052254d94f2af8d269705d49244d21af853f8d98

commit 052254d94f2af8d269705d49244d21af853f8d98
Author: jbroman <jbroman@chromium.org>
Date: Fri Dec 02 21:13:29 2016

Mark virtual/mojo-loading/http/tests/xmlhttprequest/workers/xmlhttprequest-response-type-blob.html as flaky timeout.

BUG= 659917 , 670562 
TBR=yhirano@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2547983002
Cr-Commit-Position: refs/heads/master@{#436018}

[modify] https://crrev.com/052254d94f2af8d269705d49244d21af853f8d98/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f28d5eeba2ca018e1c3995c0e9cb6a3f29b6f338

commit f28d5eeba2ca018e1c3995c0e9cb6a3f29b6f338
Author: yhirano <yhirano@chromium.org>
Date: Mon Dec 05 13:06:03 2016

Make cross-origin-preflight-get-response-type-blob fail when loading fails

BUG= 670562 
R=tzik@chromium.org

Review-Url: https://codereview.chromium.org/2550133002
Cr-Commit-Position: refs/heads/master@{#436272}

[modify] https://crrev.com/f28d5eeba2ca018e1c3995c0e9cb6a3f29b6f338/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad092abe5691a30391dbc0fd846af75e9917d37b

commit ad092abe5691a30391dbc0fd846af75e9917d37b
Author: tzik <tzik@chromium.org>
Date: Tue Jan 24 02:34:17 2017

Use associated interface on DownloadedTempFile

Blob systems depends on the ordering of loading IPC messages. That is,
the blob creation IPC via XHR is issued before the destruction of
DownloadedTempFile, and it expects to the blob IPC is handled before
DownloadedTempFile IPC.
However in the previous code, that is not guaranteed by Mojo, and that
makes Layout tests flaky. This CL switches DownLoadedTempFile in a loading
IPC to an associated interface to ensure it preserves the ordering of IPC
to other loading IPCs.

BUG= 670562 

Review-Url: https://codereview.chromium.org/2561743003
Cr-Commit-Position: refs/heads/master@{#445611}

[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/DEPS
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/downloaded_temp_file_impl.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/downloaded_temp_file_impl.h
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/test_url_loader_client.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/loader/test_url_loader_client.h
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/child/url_loader_client_impl.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/child/url_loader_client_impl.h
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/common/url_loader.mojom
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ad092abe5691a30391dbc0fd846af75e9917d37b/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 6 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Status: Fixed (was: Assigned)

Sign in to add a comment