New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670526 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility

Blocking:
issue 798003



Sign in to add a comment

Improve touch support with screen magnification

Project Member Reported by yawano@chromium.org, Dec 2 2016

Issue description

OS: Chrome OS

What steps will reproduce the problem?
(1) Turn on screen magnification from accessibility settings.
(2) Try to change zoom level or pan around by using touch.
(3) Nothing happens.

What is the expected result?
User can change zoom level or pan around by using touch.

What happens instead?
Nothing happens.
 

Comment 2 by zork@chromium.org, Mar 20 2017

Issue 418867 has been merged into this issue.

Comment 3 by zork@chromium.org, Mar 20 2017

Cc: jen...@chromium.org aboxhall@chromium.org dmazz...@chromium.org
 Issue 380328  has been merged into this issue.
Labels: NewComponent-Accessibility NewComponent-Accessibility-Features

Comment 5 by wutao@chromium.org, Apr 20 2017

Cc: wutao@chromium.org

Comment 6 by wutao@chromium.org, Apr 20 2017

The zoom level or pan around by using touch works when there is a browser. But not work for: wallpaper, file app.

It will be a problem in magnification mode if cannot pan around, meaning cannot exit the magnification mode any more.
Labels: -newcomponent-accessibility -newcomponent-accessibility-features
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38b2fad16c23a6ce94509a76c249230ad6623c17

commit 38b2fad16c23a6ce94509a76c249230ad6623c17
Author: Yuki Awano <yawano@chromium.org>
Date: Thu Aug 17 03:00:49 2017

Enable touch support for screen magnifier by default

BUG= 670526 
TEST=Enable screen magnifier and pan around with 2 fingers or change
     zoom level with 3 fingers. It should work without changing the
     flag.

Change-Id: Id817f0159a9c067d427d2ae0906d8cf3c89dc04e
Reviewed-on: https://chromium-review.googlesource.com/601730
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495061}
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/chrome/browser/about_flags.cc
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/chromeos/chromeos_switches.cc
[modify] https://crrev.com/38b2fad16c23a6ce94509a76c249230ad6623c17/chromeos/chromeos_switches.h

Comment 9 by yawano@chromium.org, Aug 17 2017

Labels: Merge-Request-61
Request merge the CL in comment 8 (https://crrev.com/c/601730) to M61.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 18 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 17 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-57 M-61
ping.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08a35ce93db1d6506571fe4362394c0673dda19d

commit 08a35ce93db1d6506571fe4362394c0673dda19d
Author: Yuki Awano <yawano@chromium.org>
Date: Thu Aug 24 01:59:15 2017

Enable touch support for screen magnifier by default

BUG= 670526 
TEST=Enable screen magnifier and pan around with 2 fingers or change
     zoom level with 3 fingers. It should work without changing the
     flag.
TBR=oshima@chromium.org, yawano@chromium.org

(cherry picked from commit 38b2fad16c23a6ce94509a76c249230ad6623c17)

Change-Id: Id817f0159a9c067d427d2ae0906d8cf3c89dc04e
Reviewed-on: https://chromium-review.googlesource.com/601730
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495061}
Reviewed-on: https://chromium-review.googlesource.com/631296
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#847}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/chrome/browser/about_flags.cc
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/chromeos/chromeos_switches.cc
[modify] https://crrev.com/08a35ce93db1d6506571fe4362394c0673dda19d/chromeos/chromeos_switches.h

Thank you! Merged the CL to M61.
Blocking: 798003
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f282275df729b57d13737b4c048271a9295c66

commit c6f282275df729b57d13737b4c048271a9295c66
Author: Yuki Awano <yawano@chromium.org>
Date: Thu Feb 01 10:49:08 2018

New touch support for screen magnification

- MagnificationController owns its GestureProvider to recognize gestures
  with screen coordinates of touch events. Logical coordinates of touch
  events cannot be used for gesture recognition as they are changed with
  viewport change: scroll, zoom.
- Use EventRewriter to see and rewrite touch events. Once
  MagnificationController detects two fingers pinch or scroll, it starts
  consuming all touch events not to confuse an app or a browser. It
  needs to rewrite events to dispatch touch cancel events.

      Confirm that user can change zoom level with two fingers pinch and
      pan around with two fingers scroll.
      Run ash_unittests:MagnificationControllerTest

Bug:  670526 
Test: Enable --ash-new-touch-support-for-screen-magnification flag.
Change-Id: I6906e5a6d93fea6f002a4fd3b83b616364a9f44b
Reviewed-on: https://chromium-review.googlesource.com/863403
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533625}
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/ash/magnifier/magnification_controller.h
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/chrome/browser/about_flags.cc
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c6f282275df729b57d13737b4c048271a9295c66/tools/metrics/histograms/enums.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41

commit d6b10e24afb1833aed4ab414fc3755fb7ebdcb41
Author: Yuki Awano <yawano@chromium.org>
Date: Wed Feb 07 01:16:00 2018

Remove --ash-new-touch-support-for-screen-magnification flag

- Enables new implementation of touch support for screen magnification
  by default.
- Removes the old implementation of touch support for screen
  magnification.

      around with two fingers scroll without any flag.
      Pass ash_unittests:MagnificationControllerTest

Bug:  670526 
Test: Confirm that you can change zoom level with pinch gesture and pan
Change-Id: Icf25edb2bceae28323075f857c3e74c2b4526dcc
Reviewed-on: https://chromium-review.googlesource.com/903306
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534861}
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/ash/magnifier/magnification_controller.h
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/chrome/browser/about_flags.cc
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d6b10e24afb1833aed4ab414fc3755fb7ebdcb41/chrome/browser/flag_descriptions.h

Labels: MagnifierCrOS
Status: Fixed (was: Assigned)

Sign in to add a comment