New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670512 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Internal error when trying to triage a flake analysis

Project Member Reported by st...@chromium.org, Dec 2 2016

Issue description

Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/20521525601d389a3b799bb2b6a5a9479fc94c13

commit 20521525601d389a3b799bb2b6a5a9479fc94c13
Author: lijeffrey <lijeffrey@chromium.org>
Date: Thu Dec 08 03:09:18 2016

[Findit] Using master flake analysis key for updating triage results

Previous internal error was due to sending the information needed to associate the result with the master flake analysis being encoded as a string 'master_name/builder_name/build_number/step_name/test_name', then splitting by '/'. However, many test names contain '/'s, leading to incorrect extraction of key components. This change encodes step and test names on the template side when passing to the triage handler, and explicitly specifies each component.

BUG= 670512 

Review-Url: https://codereview.chromium.org/2554143003

[modify] https://crrev.com/20521525601d389a3b799bb2b6a5a9479fc94c13/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/20521525601d389a3b799bb2b6a5a9479fc94c13/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/20521525601d389a3b799bb2b6a5a9479fc94c13/appengine/findit/handlers/flake/triage_flake_analysis.py
[modify] https://crrev.com/20521525601d389a3b799bb2b6a5a9479fc94c13/appengine/findit/templates/flake/result.html

Have all the analyses listed above been marked appropriately? If not, please do so before closing this bug.
Status: Fixed (was: Started)
All analyses mentioned above have been triaged accordingly.
Status: Verified (was: Fixed)

Sign in to add a comment