Issue 670510 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	bajones@chromium.org
Closed:	Feb 2018
Cc:	jmedley@google.com
Components:	Blink>WebXR
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Feature
Proj-VR Test-Complete
Proj-XR

Blocked on:
issue 670540

Blocking:
issue 779691
issue 670502

Participants' hotlists:
XR-Bugs

Implement the WebXR Device API

Project Member Reported by bajones@chromium.org, Dec 2 2016

Issue description

In M56 we are shipping the "1.1" version of the spec behind an Origin Trial. This spec version has some known shortcomings and the WebVR community group is currently discussing an update to is, which we call "1.2" for convenience. (Version numbers here do not represent spec stability.) Once that version of the spec has solidified Chrome's implementation should be updated to match.

Outstanding 1.2 spec issues can be found here:
https://github.com/w3c/webvr/milestone/3

Comment 1 by bajones@chromium.org, Sep 8 2017

Blocking: 670502
Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature
Status: Started (was: Assigned)
Summary: WebVR: Implement the "2.0" version of the spec (was: WebVR: Upgrade to the "1.2" version of the spec)

Title change to reflect current state. The latest iteration of the API is now referred to as "2.0" internally, and is currently described here: https://github.com/w3c/webvr/blob/master/explainer.md

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a63db5f510828de8e371fd1f3836d8463d20b89

commit 2a63db5f510828de8e371fd1f3836d8463d20b89
Author: Brandon Jones <bajones@chromium.org>
Date: Mon Sep 18 22:46:21 2017

Added navigator.vr attribute

This adds the "vr" attribute but not the ability to return a valid
device list. As long as the security checks pass an empty array will be
returned by the promise every time.

Bug:  670510 
Change-Id: I7e5e21d0db92b0766a74b678beb6ca90e020ced9
Reviewed-on: https://chromium-review.googlesource.com/658260
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502703}
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/vr/latest/getDevices_always_resolves.html
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_blocked_by_getVRDisplays.html
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_blocks_getVRDisplays.html
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_detached.html
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/EventTargetModulesFactory.json5
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/NavigatorVR.idl
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/latest/VR.cpp
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/latest/VR.h
[add] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/modules/vr/latest/VR.idl
[modify] https://crrev.com/2a63db5f510828de8e371fd1f3836d8463d20b89/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ff1d1646236c670843b9334a41958010344dc3f

commit 0ff1d1646236c670843b9334a41958010344dc3f
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Sep 22 18:26:50 2017

Add ability to enumerate VRDevices

Enables navigator.vr.getDevices to return the device list (which should
be identical to the one returned by navigator.getVRDisplays). The
devices should accurately populate their names and the isExternal
property, but will reject any attempt to create a session. Also enables
the "deviceconnected" and "devicedisconnected" events on navigator.vr,
though our current implementation doesn't ever disconnect a device so
that one won't fire.

Bug:  670510 
Change-Id: Ie798db94e812476b4eefb86e48695fdfe2df323e
Reviewed-on: https://chromium-review.googlesource.com/675754
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503800}
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/events_deviceconnect.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/getDevices_one_device.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/getDevices_two_devices.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/getDevices_zero_devices.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_exclusive.html
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_non_exclusive.html
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/EventTargetModulesFactory.json5
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VR.cpp
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VR.h
[modify] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VR.idl
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDevice.cpp
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDevice.h
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDevice.idl
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.cpp
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.h
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.idl
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRDeviceEventInit.idl
[add] https://crrev.com/0ff1d1646236c670843b9334a41958010344dc3f/third_party/WebKit/Source/modules/vr/latest/VRSessionCreationOptions.idl

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48315306487041b1944ea08c89288933168e9259

commit 48315306487041b1944ea08c89288933168e9259
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Sep 29 05:31:02 2017

Added VRSession creation.

This CL only enables the creation of exclusive VRSession objects. It
does not provide the ability to present to a headset, or many of the
functions of a VRSession. Those will be added in follow up CLs to allow
the more complicated logic to be reviewed independently.

Bug:  670510 
Change-Id: Ic2b3b1801bf8f3ee4263d009daab8215b0b179d5
Reviewed-on: https://chromium-review.googlesource.com/685396
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505305}
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/LayoutTests/vr/latest/events_session_end.html
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive.html
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/LayoutTests/vr/latest/vrSession_exclusive.html
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/EventTargetModulesFactory.json5
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRDevice.cpp
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSession.idl
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.cpp
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.h
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.idl
[add] https://crrev.com/48315306487041b1944ea08c89288933168e9259/third_party/WebKit/Source/modules/vr/latest/VRSessionEventInit.idl

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/510a35ab9af02d764f9780e072fe9a37bc8fbed8

commit 510a35ab9af02d764f9780e072fe9a37bc8fbed8
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Oct 10 22:16:42 2017

Added VRFrameOfReference creation

This CL enables to creation of VRFrameOfReference instances by calling
session.requestFrameOfReference. It includes all the logic necessary to handle
the frame of reference transforms, even though there is no need for them in the
code just yet. Also includes the VRStageBounds and VRStageBoundsPoint
interfaces as they are part of the VRFrameOfReference interface, but at this
time there is no way to create a VRFrameOfReference that will have non-null
bounds. (That will effectively have to wait till we have desktop support.)

Bug:  670510 
Change-Id: I68135f487b876f32a2843b29731063184150f776
Reviewed-on: https://chromium-review.googlesource.com/693051
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507792}
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/LayoutTests/vr/latest/getDevices_always_resolves.html
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/LayoutTests/vr/latest/vrSession_requestFrameOfReference.html
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/BUILD.gn
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRCoordinateSystem.cpp
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRCoordinateSystem.h
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRCoordinateSystem.idl
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.cpp
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.h
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.idl
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReferenceOptions.idl
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[modify] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRSession.idl
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.cpp
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.h
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.idl
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRStageBoundsPoint.h
[add] https://crrev.com/510a35ab9af02d764f9780e072fe9a37bc8fbed8/third_party/WebKit/Source/modules/vr/latest/VRStageBoundsPoint.idl

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566269566978baeb039a91099fe3f0c86ef52cc3

commit 566269566978baeb039a91099fe3f0c86ef52cc3
Author: Anna Maria <offenwanger@chromium.org>
Date: Tue Oct 24 02:52:17 2017

Refactor navigator.vr.getDevices into navigator.vr.requestDevice

As per: https://github.com/w3c/webvr/pull/289

Bug:  670510 
Change-Id: If87fe16e00d47f130cb1a4ce2be0eb8bb64e3284
Reviewed-on: https://chromium-review.googlesource.com/729228
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511020}
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/events_deviceconnect.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/events_session_end.html
[delete] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/third_party/WebKit/LayoutTests/vr/latest/getDevices_always_resolves.html
[delete] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/third_party/WebKit/LayoutTests/vr/latest/getDevices_two_devices.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_blocks_getVRDisplays.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_detached.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/requestDevice_always_resolves.html
[rename] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/requestDevice_one_device.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/requestDevice_two_devices.html
[rename] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/requestDevice_zero_devices.html
[delete] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive_no_gesture.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive_supported.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_requestSession_exclusive_unsupported.html
[delete] https://crrev.com/9f04c93516a88bdf1a6a7d220f91c6b1db11c1e8/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_exclusive.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_exclusive_rejects.html
[add] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_exclusive_resolves.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrDevice_supportsSession_non_exclusive.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrSession_exclusive.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/vr/latest/vrSession_requestFrameOfReference.html
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/Source/modules/vr/latest/VR.cpp
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/Source/modules/vr/latest/VR.h
[modify] https://crrev.com/566269566978baeb039a91099fe3f0c86ef52cc3/third_party/WebKit/Source/modules/vr/latest/VR.idl

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d6ee2e258b67e1ece73472285820be19fed84a5

commit 5d6ee2e258b67e1ece73472285820be19fed84a5
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Oct 24 20:23:26 2017

Added VRSession requestFrame support

This is a slightly awkward CL in that it has two routes for queuing up
the frame callback (exclusive and non-exclusive) but in this CL they
both do effectively the same thing. This is because I can't wire up the
exclusive frame loop to the VRPresentationProvider until it's actually
implemented, which will probably be the next CL after this one. (Left
out here for the sake of reviewability.)

Bug:  670510 
Change-Id: I8e00602f1ff9a4352530e489950d4dc6987b95b0
Reviewed-on: https://chromium-review.googlesource.com/724124
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511246}
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_called.html
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_invalidhandle.html
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_unregister.html
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/vr/latest/vrSession_prevent_multiple_exclusive.html
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRDevice.cpp
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRDevice.h
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRFrameProvider.cpp
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRFrameProvider.h
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallback.idl
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallbackCollection.cpp
[add] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallbackCollection.h
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[modify] https://crrev.com/5d6ee2e258b67e1ece73472285820be19fed84a5/third_party/WebKit/Source/modules/vr/latest/VRSession.idl

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/506e88d796b487d84ccc2790c063dfeb63d349ba

commit 506e88d796b487d84ccc2790c063dfeb63d349ba
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Oct 27 18:44:58 2017

Added VRDevicePose and VRPresentationFrame

Both interfaces will be expanded in future CLs, but I'm focusing on the
basics in this patch to make it easier to review.

Bug:  670510 
Change-Id: I27fd407c192ff3dabc82b148b4ad1767665f5c85
Reviewed-on: https://chromium-review.googlesource.com/738323
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512254}
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/LayoutTests/vr/latest/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/BUILD.gn
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.cpp
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.h
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.idl
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallback.idl
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallbackCollection.cpp
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallbackCollection.h
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.cpp
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.h
[add] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.idl
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/506e88d796b487d84ccc2790c063dfeb63d349ba/third_party/WebKit/Source/modules/vr/latest/VRSession.h

Comment 9 by ddorwin@chromium.org, Oct 30 2017

Blockedon: 670540

Comment 10 by ddorwin@chromium.org, Oct 30 2017

Blocking: 779691

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aed3475360eac530eb2a7f7b889fbfbbd3c5252

commit 8aed3475360eac530eb2a7f7b889fbfbbd3c5252
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Oct 31 04:52:12 2017

Added VRView

Gives the ability to get projection and view matrices for a frame.

Bug:  670510 
Change-Id: If164de438eaa88c5945b5a411e7a5cec42664fda
Reviewed-on: https://chromium-review.googlesource.com/742681
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512746}
[add] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/vr/latest/vrView_match.html
[add] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/vr/latest/vrView_oneframeupdate.html
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/vr/resources/test-constants.js
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.cpp
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.h
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.idl
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.cpp
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.h
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.idl
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[add] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRView.cpp
[add] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRView.h
[add] https://crrev.com/8aed3475360eac530eb2a7f7b889fbfbbd3c5252/third_party/WebKit/Source/modules/vr/latest/VRView.idl

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d

commit 4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Nov 03 19:51:22 2017

Added VRLayer, VRWebGLLayer, and VRViewport

WebGL Layer doesn't yet create a framebuffer, because that's way too
much additional code to cram into this CL.

Bug:  670510 
Change-Id: I5d64d264d94f76ddca9eb3add5a651a3de5b2ccc
Reviewed-on: https://chromium-review.googlesource.com/752305
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513880}
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_called.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_invalidhandle.html
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_nolayer.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_unregister.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/vrView_match.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/vrView_oneframeupdate.html
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/vr/latest/vrViewport_valid.html
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/BUILD.gn
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRLayer.cpp
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRLayer.h
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRLayer.idl
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRSession.idl
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRView.cpp
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRView.h
[modify] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRView.idl
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRViewport.h
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRViewport.idl
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.cpp
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.h
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.idl
[add] https://crrev.com/4a7df3d91ffdcde8df6107e5e7d2a4d0a2dcd78d/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayerInit.idl

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d3d14cdef6779e7eaabe74aeb3ad10fec2a17a

commit a4d3d14cdef6779e7eaabe74aeb3ad10fec2a17a
Author: David Dorwin <ddorwin@chromium.org>
Date: Tue Nov 14 22:20:50 2017

Only expose navigator.vr if the WebVR2 feature is enabled

BUG= 670510 
TEST=navigator.vr is only visible when test APIs are enabled; navigator.getVRDisplays() is only visible when enable-webvr

Change-Id: Ie8e8d5dfab4b27d32827607f5ee5f5bad20f14c0
Reviewed-on: https://chromium-review.googlesource.com/767863
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516458}
[modify] https://crrev.com/a4d3d14cdef6779e7eaabe74aeb3ad10fec2a17a/third_party/WebKit/Source/modules/vr/NavigatorVR.idl

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26d5650aa9c24dc93d2f970a011a04133f9a5c57

commit 26d5650aa9c24dc93d2f970a011a04133f9a5c57
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Nov 17 03:38:34 2017

Added VRWebGLDrawingBuffer

This adds a drawing buffer very similiar to the one that backs WebGL
contexts (and in fact borrows plenty of code from it) to create the
framebuffer that the VRWebGLLayer returns. It also introduces the
concept of an opaque framebuffer to WebGL.

This CL does not provide the code to actually push rendered content to
the VRDevice, because it's a huge change as-is, and that logic deserves
it's own review.

Bug:  670510 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie63053b733b78c22f1f6d2fc4b8b67d95aac9b82
Reviewed-on: https://chromium-review.googlesource.com/757836
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517281}
[add] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/LayoutTests/vr/latest/vrWebGLLayer_framebuffer_draw.html
[add] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/LayoutTests/vr/latest/vrWebGLLayer_opaque_framebuffer.html
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRSession.cpp
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[add] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRWebGLDrawingBuffer.cpp
[add] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRWebGLDrawingBuffer.h
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.cpp
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.h
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.idl
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
[modify] https://crrev.com/26d5650aa9c24dc93d2f970a011a04133f9a5c57/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d9b2bc729783945c8a198b62dbe8840f8e02da

commit e9d9b2bc729783945c8a198b62dbe8840f8e02da
Author: Brandon Jones <bajones@chromium.org>
Date: Mon Dec 11 22:20:11 2017

Add flag to enable WebXR, changed runtime feature name from WebVR2

Bug:  670510 
Change-Id: I4f135d13ac44ac6214b74eb03eb7734d6786a737
Reviewed-on: https://chromium-review.googlesource.com/817976
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523231}
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/chrome/browser/about_flags.cc
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/content/child/runtime_features.cc
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/content/public/common/content_features.cc
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/content/public/common/content_features.h
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/NavigatorVR.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VR.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRCoordinateSystem.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRDevice.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRDevicePose.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRLayer.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRSession.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRStageBoundsPoint.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRView.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRViewport.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/modules/vr/latest/VRWebGLLayer.idl
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/e9d9b2bc729783945c8a198b62dbe8840f8e02da/tools/metrics/histograms/enums.xml

Comment 16 by bajones@chromium.org, Dec 14 2017

Summary: Implement the WebXR Device API (was: WebVR: Implement the "2.0" version of the spec)

Updated title to match new spec name.

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e526376476bf02c445e992ac7a9359f4482b29

commit 01e526376476bf02c445e992ac7a9359f4482b29
Author: Anna Maria <offenwanger@chromium.org>
Date: Fri Dec 15 17:51:28 2017

Change all vr/latest to xr

Renaming WebVR 2 code to WebXR as per community group desision.

Bug:  670510 
Change-Id: Ia85cfe584afa3e21d4634414748e11f3c9b9bfc3
Reviewed-on: https://chromium-review.googlesource.com/823424
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524408}
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/exclusive_requestFrame_called.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_blocked_by_getVRDisplays.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_blocks_getVRDisplays.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_detached.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/navigator_vr_early_detached.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/requestDevice_always_resolves.html
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/LayoutTests/vr/latest/requestDevice_zero_devices.html
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/events_deviceconnect.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/events_session_end.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_invalidhandle.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_nolayer.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_unregister.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/navigator_xr_blocked_by_getVRDisplays.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/navigator_xr_blocks_getVRDisplays.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/navigator_xr_detached.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/navigator_xr_early_detached.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/requestDevice_always_resolves.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/requestDevice_one_device.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/requestDevice_two_devices.html
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/requestDevice_zero_devices.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_no_gesture.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_supported.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_rejects.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_resolves.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_non_exclusive.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrSession_exclusive.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrSession_prevent_multiple_exclusive.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrSession_requestFrameOfReference.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrView_match.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_draw.html
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_opaque_framebuffer.html
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/event_target_modules_names.json5
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/vr/NavigatorVR.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRCoordinateSystem.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.cpp
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.h
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRDeviceEventInit.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallback.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRFrameRequestCallbackCollection.cpp
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRLayer.cpp
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRLayer.h
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRPresentationFrame.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRSession.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.cpp
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.h
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRSessionEventInit.idl
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.h
[delete] https://crrev.com/8dfa5b8499504e4b4062ac949116b820f4196829/third_party/WebKit/Source/modules/vr/latest/VRStageBounds.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/BUILD.gn
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/DEPS
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/OWNERS
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XR.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XR.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XR.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRCoordinateSystem.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRCoordinateSystem.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRCoordinateSystem.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevice.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevice.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevice.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDeviceEvent.cpp
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDeviceEvent.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDeviceEvent.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDeviceEventInit.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevicePose.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevicePose.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRDevicePose.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameOfReference.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameOfReference.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameOfReference.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameOfReferenceOptions.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameProvider.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameRequestCallback.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameRequestCallbackCollection.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRFrameRequestCallbackCollection.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRLayer.cpp
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRLayer.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRLayer.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRPresentationFrame.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRPresentationFrame.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRPresentationFrame.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSession.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSession.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSession.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSessionCreationOptions.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSessionEvent.cpp
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSessionEvent.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSessionEvent.idl
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRSessionEventInit.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRStageBounds.cpp
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRStageBounds.h
[add] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRStageBounds.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRStageBoundsPoint.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRStageBoundsPoint.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRView.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRView.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRView.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRViewport.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRViewport.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLDrawingBuffer.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLDrawingBuffer.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLLayer.h
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLLayer.idl
[rename] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Source/modules/xr/XRWebGLLayerInit.idl
[modify] https://crrev.com/01e526376476bf02c445e992ac7a9359f4482b29/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb1f76c952e9b502774f6a987bffa296be43d076

commit bb1f76c952e9b502774f6a987bffa296be43d076
Author: Anna Maria <offenwanger@chromium.org>
Date: Tue Dec 19 23:14:18 2017

Change WebXR use deviceconnect event

The explainer has changed so that instead of deviceconnect and
devicedisconnect, we only have devicechange. also Removing DeviceEvent
as with this change it is no longer used.

Bug:  670510 
Change-Id: Ibcfde5e2765cba94eb0fc52e03287d286c3fabfa
Reviewed-on: https://chromium-review.googlesource.com/833373
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525176}
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/LayoutTests/xr/events_deviceconnect.html
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/core/events/event_type_names.json5
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/modules/xr/BUILD.gn
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/modules/xr/XR.cpp
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/modules/xr/XR.h
[modify] https://crrev.com/bb1f76c952e9b502774f6a987bffa296be43d076/third_party/WebKit/Source/modules/xr/XR.idl
[delete] https://crrev.com/2dce5eb6bcd1e42835172bcde45251ea9f3fe265/third_party/WebKit/Source/modules/xr/XRDeviceEvent.cpp
[delete] https://crrev.com/2dce5eb6bcd1e42835172bcde45251ea9f3fe265/third_party/WebKit/Source/modules/xr/XRDeviceEvent.h
[delete] https://crrev.com/2dce5eb6bcd1e42835172bcde45251ea9f3fe265/third_party/WebKit/Source/modules/xr/XRDeviceEvent.idl
[delete] https://crrev.com/2dce5eb6bcd1e42835172bcde45251ea9f3fe265/third_party/WebKit/Source/modules/xr/XRDeviceEventInit.idl

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8827d83c695b4b624437a7321331fea8357ba65a

commit 8827d83c695b4b624437a7321331fea8357ba65a
Author: Anna Maria <offenwanger@chromium.org>
Date: Thu Dec 21 00:02:56 2017

Refactor XRDevice isExternal to external to match spec

Making XRDevice match the spec:
https://immersive-web.github.io/webxr/spec/latest/#xrdevice-interface

Bug:  670510 
Change-Id: I8fc64611ed1d8b1ed430c472c9dddbe69bb08730
Reviewed-on: https://chromium-review.googlesource.com/837903
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525524}
[modify] https://crrev.com/8827d83c695b4b624437a7321331fea8357ba65a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8827d83c695b4b624437a7321331fea8357ba65a/third_party/WebKit/LayoutTests/xr/requestDevice_one_device.html
[modify] https://crrev.com/8827d83c695b4b624437a7321331fea8357ba65a/third_party/WebKit/LayoutTests/xr/requestDevice_two_devices.html
[modify] https://crrev.com/8827d83c695b4b624437a7321331fea8357ba65a/third_party/WebKit/Source/modules/xr/XRDevice.h
[modify] https://crrev.com/8827d83c695b4b624437a7321331fea8357ba65a/third_party/WebKit/Source/modules/xr/XRDevice.idl

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e

commit 8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e
Author: Anna Maria <offenwanger@chromium.org>
Date: Thu Dec 21 00:49:44 2017

Refactor XRSession requestFrame into requestAnimationFrame

Refactoring requestFrame as per https://github.com/immersive-web/webxr/commit/1631ef96c3d2924c82bed4fbb5c69c6466c1fb84#diff-817a23c792520ce222813d3eff70d031

Bug:  670510 
Change-Id: Ie7ce0aba5be3a546638affc5df39080581d92cd0
Reviewed-on: https://chromium-review.googlesource.com/837421
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525540}
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_invalidhandle.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_nolayer.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_unregister.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_draw.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_opaque_framebuffer.html
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/Source/modules/xr/XRFrameRequestCallback.idl
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/Source/modules/xr/XRFrameRequestCallbackCollection.cpp
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/Source/modules/xr/XRSession.cpp
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/Source/modules/xr/XRSession.h
[modify] https://crrev.com/8b3f7f1c5c12ce8d2f4fc1d04703071a144b201e/third_party/WebKit/Source/modules/xr/XRSession.idl

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82067c9a80fb3db0e3067467f6fd221b54f68da

commit a82067c9a80fb3db0e3067467f6fd221b54f68da
Author: Anna Maria <offenwanger@chromium.org>
Date: Mon Jan 08 20:09:44 2018

Remove deviceName from XRDevice

deviceName is removed from XRDevice as since it was used to distinguish
between multiple devices, and since the API changed to only supply one
device at a time, it is not needed.

Bug:  670510 
Change-Id: I25917654190c341f3f1b2311cabff2123ebf56b0
Reviewed-on: https://chromium-review.googlesource.com/837732
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527726}
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/LayoutTests/xr/requestDevice_one_device.html
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/LayoutTests/xr/requestDevice_two_devices.html
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/Source/modules/xr/XRDevice.cpp
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/Source/modules/xr/XRDevice.h
[modify] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/third_party/WebKit/Source/modules/xr/XRDevice.idl

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/675f9b65f39389b24bf52b369e36f673d4e076bf

commit 675f9b65f39389b24bf52b369e36f673d4e076bf
Author: Brandon Jones <bajones@chromium.org>
Date: Wed Jan 17 16:55:41 2018

Moved XRWebGLDrawingBuffer to platform/graphics/gpu

After updating the class to return a StaticBitmapImage it became obvious this
was a better location for this class. Required exposing methods to query several
previously hidden DrawingBuffer properties.

Bug:  670510 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I22e06c2c3b0f5aa227d13dd25d618a9384e24d05
Reviewed-on: https://chromium-review.googlesource.com/860918
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529773}
[add] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_constructor.html
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/BUILD.gn
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/XRSession.cpp
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/XRSession.h
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/XRWebGLLayer.h
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/modules/xr/XRWebGLLayer.idl
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[rename] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/platform/graphics/gpu/XRWebGLDrawingBuffer.cpp
[rename] https://crrev.com/675f9b65f39389b24bf52b369e36f673d4e076bf/third_party/WebKit/Source/platform/graphics/gpu/XRWebGLDrawingBuffer.h

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19bd94e2cd3156be01ffe1e8b60b943de0728b34

commit 19bd94e2cd3156be01ffe1e8b60b943de0728b34
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Jan 19 01:33:27 2018

Enabled frame submission with WebXR

Allows exclusive XRSessions to submit frames to the XR compositor, which
enables the most basic end-to-end usage of the API.

Bug:  670510 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I704aaac3325538e2db8f8b6d6f8d341492835a14
Reviewed-on: https://chromium-review.googlesource.com/871790
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530379}
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[add] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_dirty_framebuffer.html
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/Source/modules/xr/XRFrameProvider.cpp
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/Source/modules/xr/XRFrameProvider.h
[modify] https://crrev.com/19bd94e2cd3156be01ffe1e8b60b943de0728b34/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp

Comment 24 by jmedley@chromium.org, Jan 19 2018

Cc: jmedley@google.com

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149cd5b88770d785b63b5ebb27386cdf0b71a0e4

commit 149cd5b88770d785b63b5ebb27386cdf0b71a0e4
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Jan 30 05:38:31 2018

Added XRPresentationContext

This rendering context type is effectively a variant of an
ImageBitmapRenderingContext, but which can only be supplied images
directly by a XRSession.

Bug:  670510 
Change-Id: I780d47b873f4295e169d06fe993278067e99178d
Reviewed-on: https://chromium-review.googlesource.com/877182
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532777}
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/LayoutTests/external/wpt/webxr/resources/webxr_util.js
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/bindings/IDLUnionTypes.md
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/bindings/scripts/utilities.py
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/BUILD.gn
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.idl
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.h
[add] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.cpp
[add] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.h
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/xr/BUILD.gn
[add] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/xr/XRPresentationContext.cpp
[add] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/xr/XRPresentationContext.h
[add] https://crrev.com/149cd5b88770d785b63b5ebb27386cdf0b71a0e4/third_party/WebKit/Source/modules/xr/XRPresentationContext.idl

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8

commit e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8
Author: Brandon Jones <bajones@chromium.org>
Date: Sat Feb 03 06:23:07 2018

Enabled Non-Exclusive XRSession support

Allows multiple non-exclusive "magic window" XRSessions to be created, and
suspends them when an exclusive session is started.

Bug:  670510 
Change-Id: I6236c0e6f36c762a494543609645a5e6de7ec1e9
Reviewed-on: https://chromium-review.googlesource.com/898101
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534263}
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/events_session_end.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_invalidhandle.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_nolayer.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_unregister.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/resources/xr-test-utils.js
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_supported.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_non_exclusive.html
[add] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrPresentationContext_context_creation.html
[add] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrPresentationContext_preserves_canvas.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrSession_requestFrameOfReference.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_constructor.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_dirty_framebuffer.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_draw.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_opaque_framebuffer.html
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRDevice.cpp
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRSession.cpp
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRSession.h
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRSession.idl
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRSessionCreationOptions.idl
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRView.cpp
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRView.h
[modify] https://crrev.com/e26c8a0cb65f1b9da5c668ccf1d437baaaceabc8/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b79ccb84cd9b28206588bfe774a5fb0498bc109

commit 9b79ccb84cd9b28206588bfe774a5fb0498bc109
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Fri Feb 09 01:39:59 2018

Add compatibleXRDevice to WebGLContextAttributes

Adding WebGLContextAttributes attribute in compliance with changes to
WebXR spec:
https://immersive-web.github.io/webxr/spec/latest/#contextcompatibility

Bug:  670510 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I349693a2da9c0bd614ea7a410de3970114c91167
Reviewed-on: https://chromium-review.googlesource.com/895912
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535613}
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/xr/resources/xr-test-utils.js
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/xr/webGLCanvasContext_create_with_xr_device.html
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/xr/webGLCanvasContext_set_device_lost_context.html
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_incompatible_device.html
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/BUILD.gn
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributesCore.cpp
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributesCore.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/html/canvas/ImageDataColorSettings.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/BUILD.gn
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DAPITest.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/CanvasContextCreationAttributesHelpers.cpp
[add] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/CanvasContextCreationAttributesHelpers.h
[rename] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/CanvasContextCreationAttributesModule.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/htmlcanvas/HTMLCanvasElementModule.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContextBase.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasModule.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasModule.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasModule.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas/OffscreenCanvasTest.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLContextAttributes.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/xr/XRPresentationContext.cpp
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/xr/XRPresentationContext.h
[modify] https://crrev.com/9b79ccb84cd9b28206588bfe774a5fb0498bc109/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp

Comment 28 by bajones@chromium.org, Feb 14 2018

Status: Fixed (was: Started)

Initial implementation (minus the spec-in-progress input portion) is now landed. Future fixes or additions should be done against more specific bugs.

Comment 29 by dougman@chromium.org, Feb 16 2018

Labels: Test-Complete

WebXR Test Plan is available at https://docs.google.com/document/d/16p7myDBMQEMP9iGt2Yrj5fPUUjIS4BqyzHQHy5z36g0/edit#heading=h.hhaughxg0ajm

Comment 30 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR

►

Issue 670510 link

Issue metadata

Implement the WebXR Device API

Issue description

Comment 1 by bajones@chromium.org, Sep 8 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 18 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 29 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 10 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 24 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Oct 27 2017

Comment 8 Deleted

Comment 9 by ddorwin@chromium.org, Oct 30 2017

Comment 9 Deleted

Comment 10 by ddorwin@chromium.org, Oct 30 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Nov 3 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 17 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Dec 11 2017

Comment 15 Deleted

Comment 16 by bajones@chromium.org, Dec 14 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Dec 15 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Dec 19 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Dec 21 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Dec 21 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jan 8 2018

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Jan 17 2018

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Jan 19 2018

Comment 23 Deleted

Comment 24 by jmedley@chromium.org, Jan 19 2018

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Jan 30 2018

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Feb 3 2018

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Feb 9 2018

Comment 27 Deleted

Comment 28 by bajones@chromium.org, Feb 14 2018

Comment 28 Deleted

Comment 29 by dougman@chromium.org, Feb 16 2018

Comment 29 Deleted

Comment 30 by btebbs@chromium.org, Jul 4

Comment 30 Deleted

Sign in to add a comment