exo should not directly depend on ash |
|||||||||||||
Issue descriptionIn mustash, exo cannot directly talk to ash. We need to place a layer between exo and ash, so that in classic-ash mode, the layer is responsible for talking to ash, and in mustash mode, the layer talks to the window-manager/mus over mojom. It would be pretty awesome if we can introduce mojom interface that is used both in classic-ash and mustash mode.
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e5e9f467769c8f0f22577eefa7267b14fbbdbd commit 95e5e9f467769c8f0f22577eefa7267b14fbbdbd Author: penghuang <penghuang@chromium.org> Date: Wed Jan 25 00:34:31 2017 Unify window fullscreen and minimizing implementation. Currently, we have several places which implement the toggle fullscreen logic. To avoid duplicate code in WmWindow::SetFullscreen(), DesktopWindowTreeHostMus::SetFullscreen() and NativeWidgetAura::SetFullscreen(), we abstract the common logic wm::SetWindowFullscreen() in //ui/wm, and use it in those three functions. BUG= 670496 Review-Url: https://codereview.chromium.org/2625113004 Cr-Commit-Position: refs/heads/master@{#445876} [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ash/common/wm/default_state.cc [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ash/common/wm_window.cc [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/views/mus/desktop_window_tree_host_mus.h [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/views/widget/native_widget_aura.h [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/wm/core/window_util.cc [modify] https://crrev.com/95e5e9f467769c8f0f22577eefa7267b14fbbdbd/ui/wm/core/window_util.h
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/178529af33287d1459efceca6454f768f62afe7b commit 178529af33287d1459efceca6454f768f62afe7b Author: penghuang <penghuang@chromium.org> Date: Thu Jan 26 02:38:50 2017 Add an aura window property for Immersive fullscreen mode Add a property kImmersiveFullscreen, so the exo doesn't need access wm::WindowState::set_in_immersive_fullscreen directly. BUG= 670496 Review-Url: https://codereview.chromium.org/2645673003 Cr-Commit-Position: refs/heads/master@{#446212} [modify] https://crrev.com/178529af33287d1459efceca6454f768f62afe7b/ash/common/wm_window.cc [modify] https://crrev.com/178529af33287d1459efceca6454f768f62afe7b/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/178529af33287d1459efceca6454f768f62afe7b/ui/aura/client/aura_constants.cc [modify] https://crrev.com/178529af33287d1459efceca6454f768f62afe7b/ui/aura/client/aura_constants.h [modify] https://crrev.com/178529af33287d1459efceca6454f768f62afe7b/ui/aura/mus/property_converter.cc
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac commit ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac Author: penghuang <penghuang@chromium.org> Date: Wed Feb 08 22:29:42 2017 exo: Do not call UpdateShelfStateForFullscreenChange() in ShellSurface ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() will call UpdateShelfVisibility() to update shelf visibility for window state changes for every window. So we don't need update shell visibility for exo Window anymore. BUG= 670496 Review-Url: https://codereview.chromium.org/2687683004 Cr-Commit-Position: refs/heads/master@{#449110} [modify] https://crrev.com/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac/components/exo/shell_surface.cc
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d1ee017dbdb0d8e3890d40891dbb52ac53ed84f commit 7d1ee017dbdb0d8e3890d40891dbb52ac53ed84f Author: penghuang <penghuang@chromium.org> Date: Fri Feb 10 22:04:03 2017 exo: ShellSurface: Remove the CustomWindowStateDelegate With CL [1], the ash will restore previous show state after exiting fullscreen. So we don't need the CustomWindowStateDelegate to restore the previous show state anymore. [1] https://codereview.chromium.org/2622053004 BUG= 670496 Review-Url: https://codereview.chromium.org/2679403003 Cr-Commit-Position: refs/heads/master@{#449748} [modify] https://crrev.com/7d1ee017dbdb0d8e3890d40891dbb52ac53ed84f/components/exo/shell_surface.cc
,
Mar 1 2017
,
Mar 1 2017
,
Mar 1 2017
,
Mar 1 2017
,
Jun 2 2017
,
Jun 2 2017
,
Sep 20 2017
,
Sep 20 2017
,
Sep 20 2017
,
Feb 26 2018
,
Apr 19 2018
,
Sep 10
exo has ash are in the same process. So it should be fine now. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by fsam...@chromium.org
, Dec 9 2016