Issue 654909 has been fixed, but we should have an automated test to check for regressions once we can actually start making automated WebVR tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41 commit ed03ff2faec8339e93a7c48ef5213d4d73fc4f41 Author: bsheedy <bsheedy@chromium.org> Date: Sat Jan 07 01:55:25 2017 Add more WebVR layout tests, adjust test format Adds a handful of new WebVR layout tests using mocking. Adjusts the vr_test to pass the provided function an async_test handle. This was done due to how easy it was for the previous promise_test implementation to resolve earlier than expected, causing the test to pass before all code was run with no visible difference in the output. The use of the async_test makes the tests slightly more verbose, but ensures that we're only ending the test when we expect to. Add a fix for VRDisplay not initializing layer bounds to defaults correctly. BUG= 675325 , 670490 ,650703 Review-Url: https://codereview.chromium.org/2617183002 Cr-Commit-Position: refs/heads/master@{#442135} [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/resources/test-constants.js [add] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/LayoutTests/vr/stageParameters_match.html [modify] https://crrev.com/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/161af0077dffbdd6aa5846677da04c4e3d3d6677 commit 161af0077dffbdd6aa5846677da04c4e3d3d6677 Author: vitaliii <vitaliii@chromium.org> Date: Mon Jan 09 12:16:11 2017 Revert of Add more WebVR layout tests, adjust test format (patchset #4 id:60001 of https://codereview.chromium.org/2617183002/ ) Reason for revert: Two of the added tests crash: vr/requestAnimationFrame_invalidhandle.html vr/requestAnimationFrame_unregister.html BUG= 679288 Original issue's description: > Add more WebVR layout tests, adjust test format > > Adds a handful of new WebVR layout tests using mocking. > > Adjusts the vr_test to pass the provided function an async_test handle. This > was done due to how easy it was for the previous promise_test implementation > to resolve earlier than expected, causing the test to pass before all code was > run with no visible difference in the output. The use of the async_test makes > the tests slightly more verbose, but ensures that we're only ending the test > when we expect to. > > Add a fix for VRDisplay not initializing layer bounds to defaults correctly. > > BUG= 675325 , 670490 ,650703 > > Review-Url: https://codereview.chromium.org/2617183002 > Cr-Commit-Position: refs/heads/master@{#442135} > Committed: https://chromium.googlesource.com/chromium/src/+/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41 TBR=bajones@chromium.org,dglazkov@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 675325 , 670490 ,650703 Review-Url: https://codereview.chromium.org/2616403002 Cr-Commit-Position: refs/heads/master@{#442237} [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/resources/test-constants.js [delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/stageParameters_match.html [modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4 commit 20e4bfed4baf6f6eac0d7142bb9e763bc11512e4 Author: bsheedy <bsheedy@chromium.org> Date: Tue Jan 10 02:04:49 2017 Reland 2617183002 without offending tests 2617183002 was reverted in https://bugs.chromium.org/p/chromium/issues/detail?id=679288 due to a couple of leaking tests. This is being investigated in https://bugs.chromium.org/p/chromium/issues/detail?id=679401, but in the meantime, we can re-land the other tests that weren't causing issues. BUG= 675325 , 670490 ,650703 Review-Url: https://codereview.chromium.org/2623613002 Cr-Commit-Position: refs/heads/master@{#442447} [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/resources/test-constants.js [add] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/LayoutTests/vr/stageParameters_match.html [modify] https://crrev.com/20e4bfed4baf6f6eac0d7142bb9e763bc11512e4/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
Closing, as a test for this has been landed and running continuously.
Comment 1 by ddorwin@chromium.org
, Dec 8 2016