GLCopyTextureCHROMIUMTest.CopyTextureBetweenTexture2DAndRectangleArb in gl_tests on GPU FYI bots |
||
Issue descriptionSee https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29/builds/944/steps/gl_tests/logs/stdio as an example sample errors: ../../gpu/command_buffer/tests/gl_test_utils.cc:232: Failure Value of: actual Actual: '\xE4' (228) Expected: expected Which is: '\xC7' (199) at 14, 11 channel 1 ../../gpu/command_buffer/tests/gl_test_utils.cc:232: Failure Value of: actual Actual: '\xE4' (228) Expected: expected Which is: '\xC7' (199) at 14, 11 channel 2 ../../gpu/command_buffer/tests/gl_test_utils.cc:232: Failure Value of: actual Actual: '\xE4' (228) Expected: expected Which is: '\xC7' (199) at 14, 12 channel 0 ../../gpu/command_buffer/tests/gl_test_utils.cc:232: Failure Value of: actual Actual: '\xE4' (228) Expected: expected Which is: '\xC7' (199) at 14, 12 channel 1 ../../gpu/command_buffer/tests/gl_test_utils.cc:232: Failure Value of: actual Actual: '\xE4' (228) Expected: expected Which is: '\xC7' (199) at 14, 12 channel 2 [ FAILED ] GLCopyTextureCHROMIUMTest.CopyTextureBetweenTexture2DAndRectangleArb (98 ms)
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25a5b0aa58a30bbbffe5f2bb197436044ce80832 commit 25a5b0aa58a30bbbffe5f2bb197436044ce80832 Author: enne <enne@chromium.org> Date: Thu Dec 01 23:51:53 2016 Revert of Add command buffer support for EXT_sRGB_write_control (patchset #9 id:160001 of https://codereview.chromium.org/2519603002/ ) Reason for revert: Breaks gl_tests on GPU FYI bots BUG= 670487 Original issue's description: > Add command buffer support for EXT_sRGB_write_control > > This state is not set in the service side at glEnable/glDisable time. > Instead, it is set during framebuffer validation, to accommodate > driver bug workarounds on desktop. > > Move the logic for updating framebuffer SRGB in the decoder to > a separate function, GLES2DecoderImpl::UpdateFramebufferSRGB. > > BUG=655247 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/a48dcecc89523bf034b2138c308fc959380c8028 > Cr-Commit-Position: refs/heads/master@{#435631} TBR=zmo@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655247 Review-Url: https://codereview.chromium.org/2537343008 Cr-Commit-Position: refs/heads/master@{#435773} [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/context_state.cc [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/context_state.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/context_state_autogen.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/context_state_impl_autogen.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/feature_info.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/feature_info_unittest.cc [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/25a5b0aa58a30bbbffe5f2bb197436044ce80832/gpu/command_buffer/tests/gl_test_utils.cc
,
Dec 6 2016
This has been re-landed in crrev.com/436555. The second landing makes FRAMEBUFFER_SRGB not be initialized by default (it relies on the lazy initialization). |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 1 2016