New issue
Advanced search Search tips

Issue 670470 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Remove xdisplaycheck

Project Member Reported by thomasanderson@chromium.org, Dec 1 2016

Issue description

xdisplaycheck was used in xvfb.py to ensure the virtual X server was properly initialized before running any tests.  However, xvfb is bundled with a utility called xvfb-run which achieves the same end.  xdisplaycheck is therefore no longer needed.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca74e347e8b31645821402157065c7240d79f3f

commit cca74e347e8b31645821402157065c7240d79f3f
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Dec 06 17:13:23 2016

Remove xdisplaycheck from the tree

R=dpranke@chromium.org,ben@chromium.org
BUG=670470

Review-Url: https://codereview.chromium.org/2530463002
Cr-Commit-Position: refs/heads/master@{#436624}

[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/blimp/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/chrome/test/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/components/exo/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/content/shell/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/media/midi/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/services/ui/ws/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/tools/mb/mb.py
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/tools/perf/chrome_telemetry_build/BUILD.gn
[delete] https://crrev.com/ac29ce36280dc4cb2b63497f88abff0489edd774/tools/xdisplaycheck/BUILD.gn
[delete] https://crrev.com/ac29ce36280dc4cb2b63497f88abff0489edd774/tools/xdisplaycheck/xdisplaycheck.cc
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/ui/base/BUILD.gn
[modify] https://crrev.com/cca74e347e8b31645821402157065c7240d79f3f/ui/gl/BUILD.gn

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.
Status: Assigned (was: Started)

Sign in to add a comment