New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: The Infobar arrow doesn't appear anymore in Fullscreen Mode

Project Member Reported by meh...@chromium.org, Dec 1 2016

Issue description

Chrome Version: Chrome 57.0.2938.0 canary (64-bit)
OS: Mac OS 10.11.6

What steps will reproduce the problem?
(1) open a page so that one of the infobars (e.g. the Translate infobar) appear
(2) Compare it in Fullscreen and in Non-Fullscreen window


What is the expected result? What happens instead?
The arrow is only to see in Non-Fullscreen. 

Please use labels and text to provide additional information.
I think the arrow was implemented for security reasons and should be fixed again for Fullscreen windows.

Screenshots are attached.

Thanks and regards
Mehmet

 
Fullscreen.png
57.8 KB View Download
Non-Fullscreen.png
74.8 KB View Download
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Components: UI>Browser>FullScreen
spqchan@ Thanks for looking into the issue. Should we remove the "Needs-Bisect" label, or do we need the exact CL from the Bisect-Team that causes this bug? Thanks.
A bisect will be helpful for this. Thanks!
Cc: nyerramilli@chromium.org ranjitkan@chromium.org
 Issue 674427  has been merged into this issue.

Comment 7 by shrike@chromium.org, Jan 25 2017

Labels: -M-56 Hotlist-PlatformExcellence-2017-Q1 M-57 ReleaseBlock-Stable
spqchan@ Since this issue is marked as RB-Stable and observed in latest canary #58.0.2997.0 on mac 10.12.2
Can we get any latest update on this issue?

Thanks!
Gentle ping..!Issue still seen on 58.0.3000.0, could you please take a look into this.
Status: Started (was: Assigned)
CL in review
Labels: Merge-Request-57
The CL has landed:

https://chromium.googlesource.com/chromium/src/+/a7140be113cefff6413d285e9bce20b513f52686

commit	a7140be113cefff6413d285e9bce20b513f52686	[log] [tgz]
author	spqchan <spqchan@chromium.org>	Thu Feb 02 18:39:19 2017
committer	Commit bot <commit-bot@chromium.org>	Thu Feb 02 18:39:19 2017
tree	9ac0dc28817cf1ef6f5f148aba712dbabbcbefde
parent	5e86b62256b5d7cdc7a10f57c06a1b040e2bbede [diff]
[Mac] Fullscreen layout issues

- Fixed the incorrect y offset for tab detached windows in fullscreen
- Fixed the layout issue with the infobar in fullscreen

BUG= 670445 , 678204 

Review-Url: https://codereview.chromium.org/2666213003
Cr-Commit-Position: refs/heads/master@{#447804}
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7140be113cefff6413d285e9bce20b513f52686

commit a7140be113cefff6413d285e9bce20b513f52686
Author: spqchan <spqchan@chromium.org>
Date: Thu Feb 02 18:39:19 2017

[Mac] Fullscreen layout issues

- Fixed the incorrect y offset for tab detached windows in fullscreen
- Fixed the layout issue with the infobar in fullscreen

BUG= 670445 , 678204 

Review-Url: https://codereview.chromium.org/2666213003
Cr-Commit-Position: refs/heads/master@{#447804}

[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
[modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Project Member

Comment 13 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9045f614d43726ac315078312899f4973db5be64

commit 9045f614d43726ac315078312899f4973db5be64
Author: spqchan <spqchan@chromium.org>
Date: Fri Feb 03 21:32:39 2017

[Mac] Fullscreen layout issues

- Fixed the incorrect y offset for tab detached windows in fullscreen
- Fixed the layout issue with the infobar in fullscreen

BUG= 670445 , 678204 

Review-Url: https://codereview.chromium.org/2666213003
Cr-Commit-Position: refs/heads/master@{#447804}
(cherry picked from commit a7140be113cefff6413d285e9bce20b513f52686)

Review-Url: https://codereview.chromium.org/2671073002 .
Cr-Commit-Position: refs/branch-heads/2987@{#300}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
[modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Labels: TE-Verified-M57 TE-Verified-57.0.2987.37
Verified this issue on Mac OS 10.12 using chrome latest M57-57.0.2987.37 by following steps mentioned in the original comment. Observed the info bar arrow is displayed in fullscreen mode as well. Hence adding TE-Verified label.

Thanks!
Screen Shot 2017-02-08 at 3.00.15 PM.png
33.1 KB View Download
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Status: Fixed (was: Started)

Comment 18 by sdy@chromium.org, Mar 4 2017

Labels: Hotlist-PlatformExcellence
Labels: -Hotlist-PlatformExcellence -Hotlist-PlatformExcellence-2017-Q1

Sign in to add a comment