New issue
Advanced search Search tips

Issue 670441 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: Double-tapping "Enter VR" breaks poses

Project Member Reported by klausw@chromium.org, Dec 1 2016

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Go to https://webvr.info/samples/03-vr-presentation.html
(2) tap "Enter VR" button once, go through Daydream flow
(3) press "back
(4) quickly double-tap "Enter VR"

What is the expected result?
Normal VR presentation

What happens instead?
A red "presentation failed" message shows, it enters VR presentation but doesn't appear to have poses, it doesn't react to movement. Exiting and re-entering presentation normally seems to get things working again.
 
Owner: ----
Status: Available (was: Untriaged)
In current "Chrome Canary" 57.0.2938.0, the double-tap either results in stuck reprojection (reusing the same pose, content moves but has huge black borders), and also often results in a black screen with just the divider + X + gear showing. Possibly related to  http://crbug.com/667327  ?
Labels: Proj-VR
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2fff71ca63ff58973e36c6f411a78f04bcc7fb

commit dd2fff71ca63ff58973e36c6f411a78f04bcc7fb
Author: bajones <bajones@chromium.org>
Date: Sat Dec 03 01:37:06 2016

Prevent repeated VRDisplay.requestPresent calls from spamming the device

With this patch new requestPresent calls that are made while the first one is
still pending will simply be queued up Blink-side and all resolved at once when
the original request succeeds or fails.

BUG= 670441 

Review-Url: https://codereview.chromium.org/2550863002
Cr-Commit-Position: refs/heads/master@{#436132}

[modify] https://crrev.com/dd2fff71ca63ff58973e36c6f411a78f04bcc7fb/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/dd2fff71ca63ff58973e36c6f411a78f04bcc7fb/third_party/WebKit/Source/modules/vr/VRDisplay.h

Labels: Merge-Request-56
Owner: bajones@chromium.org
Status: Fixed (was: Available)

Comment 6 by dimu@chromium.org, Dec 4 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c634718cdaed84e3f68f324f72908be66a2310e3

commit c634718cdaed84e3f68f324f72908be66a2310e3
Author: Brandon Jones <bajones@chromium.org>
Date: Mon Dec 05 17:39:10 2016

Prevent repeated VRDisplay.requestPresent calls from spamming the device

With this patch new requestPresent calls that are made while the first one is
still pending will simply be queued up Blink-side and all resolved at once when
the original request succeeds or fails.

BUG= 670441 

Review-Url: https://codereview.chromium.org/2550863002
Cr-Commit-Position: refs/heads/master@{#436132}
(cherry picked from commit dd2fff71ca63ff58973e36c6f411a78f04bcc7fb)

Review URL: https://codereview.chromium.org/2553753002 .

Cr-Commit-Position: refs/branch-heads/2924@{#335}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c634718cdaed84e3f68f324f72908be66a2310e3/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/c634718cdaed84e3f68f324f72908be66a2310e3/third_party/WebKit/Source/modules/vr/VRDisplay.h

Labels: M-56
Components: Blink>WebXR

Sign in to add a comment