Notification icon should not animate for "Download pending..." case |
||||||||
Issue descriptionBreaking out this issue from 658744
,
Dec 1 2016
,
Dec 2 2016
https://codereview.chromium.org/2542563006/ has landed to fix the problem
,
Dec 2 2016
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7fb021034c6274c8157d57de81ec419fa221c49 commit e7fb021034c6274c8157d57de81ec419fa221c49 Author: Min Qin <qinmin@chromium.org> Date: Fri Dec 02 18:41:35 2016 Don't animate the notification for pending download using stat_sys_download_done, which is the first frame of the animation TBR=dfalcantara@chromium.org BUG= 670428 Review-Url: https://codereview.chromium.org/2542563006 Cr-Commit-Position: refs/heads/master@{#435870} (cherry picked from commit 601e4f48a3db0aa334f325c03071f5b1d7c4093b) Review URL: https://codereview.chromium.org/2545003003 . Cr-Commit-Position: refs/branch-heads/2924@{#290} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e7fb021034c6274c8157d57de81ec419fa221c49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Dec 2 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 6 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2016
Lets merge it into M56
,
Dec 7 2016
It looks like the merge came before the label was updated to Merge-Approved-56, therefore there is nothing really more to do here, but removing Merge-Approved label.
,
Dec 7 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dougarnett@chromium.org
, Dec 1 2016