This causes screen lock pref not respected in M59.

More specifically, we lock the screen before suspending if you had the "Require password to wake from sleep" pref already set when you logged in. If you didn't have it set before and just set it, we won't lock until you log out once and log back in.

Confirmed not an issue in 58.0.3029.98 (stable)

https://codereview.chromium.org/2873453003/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f44a4a580cff9bbfc7f2125f33602f5bbb99c5

commit 33f44a4a580cff9bbfc7f2125f33602f5bbb99c5
Author: xiyuan <xiyuan@chromium.org>
Date: Tue May 09 17:35:29 2017

cros: Update ash when prefs related to lock are changed

BUG= 670423 
TEST=SessionControllerClientTest.UserPrefsChange

Review-Url: https://codereview.chromium.org/2873453003
Cr-Commit-Position: refs/heads/master@{#470368}

[modify] https://crrev.com/33f44a4a580cff9bbfc7f2125f33602f5bbb99c5/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/33f44a4a580cff9bbfc7f2125f33602f5bbb99c5/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/33f44a4a580cff9bbfc7f2125f33602f5bbb99c5/chrome/browser/ui/ash/session_controller_client_unittest.cc

Please tag with applicable OSs.  Thanks!

This is for ChromeOS.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The CL does not merge cleanly on M59. Some of the missed commits on M59 are a bit big. I will manually merge and hopefully does not create a future merge nightmare. :(

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef4589a2e06253ca91eff0b88ad52c11bf2ce896

commit ef4589a2e06253ca91eff0b88ad52c11bf2ce896
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu May 11 17:30:16 2017

Merge "cros: Update ash when prefs related to lock are changed"

> BUG= 670423 
> TEST=SessionControllerClientTest.UserPrefsChange
>
> Review-Url: https://codereview.chromium.org/2873453003
> Cr-Commit-Position: refs/heads/master@{#470368}
> (cherry picked from commit 33f44a4a580cff9bbfc7f2125f33602f5bbb99c5)

https: //chromium-review.googlesource.com/478055
https: //codereview.chromium.org/2832903002/
Review-Url: https://codereview.chromium.org/2878723002 .
Cr-Commit-Position: refs/branch-heads/3071@{#514}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/ui/ash/session_controller_client_unittest.cc
[modify] https://crrev.com/ef4589a2e06253ca91eff0b88ad52c11bf2ce896/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc