Requesting merge to M-56 so that we can test the feature in release mode.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/658a3dc11300924b70ac3097922b8ae0cd632798

commit 658a3dc11300924b70ac3097922b8ae0cd632798
Author: kerrnel <kerrnel@chromium.org>
Date: Tue Dec 06 18:12:37 2016

Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG= 670421 

Review-Url: https://codereview.chromium.org/2544133002
Cr-Commit-Position: refs/heads/master@{#436646}

[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/app/generated_resources.grd
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/browser/about_flags.cc
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/common/chrome_features.cc
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/chrome/common/chrome_features.h
[modify] https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798/tools/metrics/histograms/histograms.xml

Has this been tested on canary builds?

No, I was going to do that as soon as a canary build comes out with this change and then merge. Would you rather I request the approval after?

Yes that's preferable. Thanks

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12878e02ab6c986cb099f7bce554b39305fa514

commit a12878e02ab6c986cb099f7bce554b39305fa514
Author: kerrnel <kerrnel@chromium.org>
Date: Fri Dec 09 23:40:13 2016

Revert "Add flags entries to test chrome OS component updates in release mode."

This reverts commit 658a3dc11300924b70ac3097922b8ae0cd632798, which did
not work-as-intended because the Chrome feature flags are not available
at the time of zygote initialization.

BUG= 670421 
TBR=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2567773002
Cr-Commit-Position: refs/heads/master@{#437697}

[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/app/generated_resources.grd
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/browser/about_flags.cc
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/common/chrome_features.cc
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/chrome/common/chrome_features.h
[modify] https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514/tools/metrics/histograms/histograms.xml

Background on the revert: The "component flash only" flag did not work as intended, so I am about to land another CL with only the flag to enable component updates as a feature. We can safely merge that to M56 once I test it in a canary.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22db7c938623cc9e8b2308a715dd44645dac0a98

commit 22db7c938623cc9e8b2308a715dd44645dac0a98
Author: kerrnel <kerrnel@chromium.org>
Date: Sat Dec 10 19:09:37 2016

Add flags entry to enable Chrome OS component updates fature.

This adds an entry to about:flags so that users, and internal testers,
can opt into Chrome OS component updates before we roll them out to all
users.

This was originally landed in https://codereview.chromium.org/2544133002,
but reverted in https://codereview.chromium.org/2567773002
because one of the other flags did not work properly.

BUG= 670421 

Review-Url: https://codereview.chromium.org/2565043002
Cr-Commit-Position: refs/heads/master@{#437774}

[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/chrome/app/generated_resources.grd
[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/chrome/browser/about_flags.cc
[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/chrome/common/chrome_features.cc
[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/chrome/common/chrome_features.h
[modify] https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98/tools/metrics/histograms/histograms.xml

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I verified this in a dev mode image: 57.0.2951.0. Backporting to M56.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07db08c0e9cecfe0c08d1d776cd33116b62ae0da

commit 07db08c0e9cecfe0c08d1d776cd33116b62ae0da
Author: Greg Kerr <kerrnel@chromium.org>
Date: Wed Dec 14 23:14:03 2016

Add flags entry to enable Chrome OS component updates fature.

This adds an entry to about:flags so that users, and internal testers,
can opt into Chrome OS component updates before we roll them out to all
users.

This was originally landed in https://codereview.chromium.org/2544133002,
but reverted in https://codereview.chromium.org/2567773002
because one of the other flags did not work properly.

BUG= 670421 

Review-Url: https://codereview.chromium.org/2565043002
Cr-Commit-Position: refs/heads/master@{#437774}
(cherry picked from commit 22db7c938623cc9e8b2308a715dd44645dac0a98)

Review-Url: https://codereview.chromium.org/2578783002 .
Cr-Commit-Position: refs/branch-heads/2924@{#498}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/chrome/app/generated_resources.grd
[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/chrome/browser/about_flags.cc
[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/chrome/common/chrome_features.cc
[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/chrome/common/chrome_features.h
[modify] https://crrev.com/07db08c0e9cecfe0c08d1d776cd33116b62ae0da/tools/metrics/histograms/histograms.xml

I verified the flag in M56 dev image, build 9000.31.0.