New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670420 link

Starred by 1 user
Status: Fixed
Owner:
█ w...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove unused functions: Renderer::HasAudio()/HasVideo()

Project Member Reported by w...@chromium.org, Dec 1 2016 
This was used to report MetaData, e.t. 

https://codereview.chromium.org/418143005

metadata.has_audio = renderer_->HasAudio();
metadata.has_video = renderer_->HasVideo();

Now this is set based on the stream we have

https://cs.chromium.org/chromium/src/media/base/pipeline_impl.cc?rcl=14805370
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57a95b6adf89949133e7947cc313d6de2b8c8bcb

commit 57a95b6adf89949133e7947cc313d6de2b8c8bcb
Author: watk <watk@chromium.org>
Date: Thu Dec 01 21:24:29 2016

media: remove unused functions: Renderer::HasAudio()/HasVideo()

These are unused so now they're gone.

BUG= 670420 
TEST=compiles

Review-Url: https://codereview.chromium.org/2541803003
Cr-Commit-Position: refs/heads/master@{#435716}

[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/chromecast/media/service/cast_renderer.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/chromecast/media/service/cast_renderer.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/content/browser/media/android/media_player_renderer.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/content/browser/media/android/media_player_renderer.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/content/renderer/media/android/media_player_renderer_client.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/content/renderer/media/android/media_player_renderer_client.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/base/pipeline_impl_unittest.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/base/renderer.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/mojo/clients/mojo_renderer.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/mojo/clients/mojo_renderer.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/remoting/remote_renderer_impl.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/remoting/remote_renderer_impl.h
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/renderers/renderer_impl.cc
[modify] https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb/media/renderers/renderer_impl.h

Comment 2 by w...@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment