New issue
Advanced search Search tips

Issue 670417 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Revealing a location in minified source positions the caret almost out of view

Project Member Reported by paulir...@chromium.org, Dec 1 2016

Issue description

See the attached screenshots.
The caret in the second screenshot is blinking, but it's very hard to locate.

Things that would help:
* location is centered horizontally in the sources viewport
* location is easier to see 

Other ideas
* highlight fade takes longer. it always disappears before i've found the place
* caret is louder? (see highlight-centered.png)

 
Screen Shot 2016-12-01 at 11.57.06 AM.png
30.1 KB View Download
Screen Shot 2016-12-01 at 11.58.22 AM.png
236 KB View Download
highlight-centered.png
218 KB View Download
Owner: einbinder@chromium.org
Joel wanted to highlight either gutter or the whole line. This should help a lot!
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5

commit f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5
Author: dgozman <dgozman@chromium.org>
Date: Mon Dec 12 22:43:18 2016

[DevTools] Make line highlight stay in readonly editor.

With no cursor in readonly editor, highlight disappears very fast and
it's impossible to say where it was.

BUG= 670417 

Review-Url: https://codereview.chromium.org/2574443003
Cr-Commit-Position: refs/heads/master@{#437938}

[modify] https://crrev.com/f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[modify] https://crrev.com/f6b3c2daf84f02f4c39bae6c42460c6d8d1fe8c5/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css

Can we close the bug?
Status: Archived (was: Assigned)
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.

Sign in to add a comment