New issue
Advanced search Search tips

Issue 670409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

Multiple virtual/mojo-loading/http/tests tests fail when run with --site-per-process flag

Project Member Reported by lukasza@chromium.org, Dec 1 2016

Issue description

A recent CL (r435577) added a virtual test suite for running http/tests with --enable-blink-features=LoadingWithMojo flag.  Multiple tests added here fail when run with --site-per-process flag (making https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win red).
 
Some of these failures are unique to virtual/mojo-loading, but some could have been prevented if we only had support for inheriting test expectations - tracked in issue 594216.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9747e02f384fecf9306345936122f77034db6181

commit 9747e02f384fecf9306345936122f77034db6181
Author: lukasza <lukasza@chromium.org>
Date: Fri Dec 02 01:14:27 2016

Test expectations for virtual/mojo-loading and --site-per-process flag.

BUG= 670409 
NOTRY=true

Review-Url: https://codereview.chromium.org/2547733002
Cr-Commit-Position: refs/heads/master@{#435803}

[modify] https://crrev.com/9747e02f384fecf9306345936122f77034db6181/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a690496daee7b7023cdacdffb572a3efb5499915

commit a690496daee7b7023cdacdffb572a3efb5499915
Author: yhirano <yhirano@chromium.org>
Date: Thu Dec 22 07:34:20 2016

Fix pixel-crack-image-background-webkit-transform-scale test with mojo-loading

Due to the issue described in  https://crbug.com/675870 , the layout test fails
with mojo-loading enabled. This CL adds a workaround for the issue.

BUG= 675870 ,  670409 , 640634

Review-Url: https://codereview.chromium.org/2593403002
Cr-Commit-Position: refs/heads/master@{#440352}

[modify] https://crrev.com/a690496daee7b7023cdacdffb572a3efb5499915/third_party/WebKit/LayoutTests/images/pixel-crack-image-background-webkit-transform-scale.html

Status: Fixed (was: Assigned)

Sign in to add a comment